On Wed, Dec 28, 2016 at 04:47:55PM +0800, Heyi Guo wrote:
Hi Leif,
Refine this path according you and Graeme's comments,
please help to review, thanks.
Thanks and Regards,
Heyi
在 2016/12/28 16:42, Chenhui Sun 写道:
From: Heyi Guo heyi.guo@linaro.org
D05 has 4 physical NIC ports, which can be extended to 8 ports using an expansion card. However, the existing ACPI tables unconditionally describes the potential maximum of 8.
This patch add _STA method to the extra 4 ports from ACPI. The _STA will return the actual value when code has been added to dynamically detect whether they are present.
This patch resolves https://bugs.linaro.org/show_bug.cgi?id=2714.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo heyi.guo@linaro.org
Chips/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
diff --git a/Chips/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl b/Chips/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl index 046257b..14a905d 100644 --- a/Chips/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl +++ b/Chips/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl @@ -662,6 +662,10 @@ Scope(_SB) Package () {"port-idx-in-ae", 2}, } })
I think you misunderstood what I meant.
I meant something like (untested)
Name (NICE, 0)
Method (_STA, 0x0, NotSerialized) { Return (NICE); }
Then if my thinking is correct a later SSDT loaded when the extender is present could then
Store (\_SB.XXXX.NICE, 1)
To change the status.
Otherwise if this does not work how I think it should this patch is fine for me.
Thanks
Graeme
- Method (_STA, 0x0, NotSerialized)
- {
Return (0)- } } Device (ETH3) { Name(_HID, "HISI00C2")
@@ -674,6 +678,10 @@ Scope(_SB) Package () {"port-idx-in-ae", 3}, } })
- Method (_STA, 0x0, NotSerialized)
- {
Return (0)- } } Device (ROCE) {
@@ -1216,6 +1224,10 @@ Scope(_SB) Package () {"port-idx-in-ae", 0}, } })
- Method (_STA, 0x0, NotSerialized)
- {
Return (0)- } } Device (ETH7) { Name(_HID, "HISI00C2")
@@ -1228,6 +1240,10 @@ Scope(_SB) Package () {"port-idx-in-ae", 1}, } })
- Method (_STA, 0x0, NotSerialized)
- {
Return (0)- } } }