Hi,
It turned out that there was no quick method to do all the cleanups, but after 14 straight hours I resend network support with all your remarks about the library applied. I did much more than that - details can be found in the changelog. I hope it's much closer to be sufficient.
The patches are also available in the public github tree: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/opp-...
I'm looking forward to your comments. In the meantime I will finalize updating the driver (patches 2 and 3) after your review.
Best regards, Marcin
Changelog: v2 -> v3
* Library - fully adjust to EDK2 coding style: - fix indentation, more efficient line breaking, blank line before comments, etc. - add spaces before '(' - align indentation and cleanup Mvpp2LibHw.h - adjust function declaration/definition to multiline format - set all functions' fields and local variables to begin with capital letters - unify same arguments to be used with consistent naming among functions - add comments for parser magic values (mostly TCAM/SRAM byte count here and there) - use local variables in order to simplify Mvpp2PrsSramOffsetSet()
* Driver - set all functions' fields and local variables to begin with capital letters
v1->v2
* Separate HW part of library header - Mvpp2LibHw.h - contains all HW-related defines and structures' definitions - Mvpp2Lib.h - library function prototypes and inline functions - Pp2Dxe.h - OS glue, macros, structures, driver constants
* Remove all Marvell-specific typedefs - MV_U8, MV_32 and so on
* Adjust code to UEFI coding style - Use typedefs for structures - Replace tabs with spaces - Replace "static" prefixes with "STATIC" - Change under_score style to CamelCase - Adjust namings accordingly - Commits currently passed PatchCheck test
* Improvements/fixes - Remove Linux-related leftovers in Pp2Dxe.h - Change library headers to BSD - only - Remove duplicated AXI configuration - Enable setting MAC address with PCD's - Implement Snp->StationAddress callback for resetting/updating MAC address
Bartosz Szczepanek (3): Drivers/Net: Import Mvpp2Lib for Pp2Dxe driver Drivers/Net: Create Pp2Dxe driver Platforms/Marvell: Enable Pp2Dxe driver on Armada70x0 platform
Documentation/Marvell/PortingGuide/Pp2.txt | 70 + Drivers/Net/Pp2Dxe/Mvpp2Lib.c | 4945 ++++++++++++++++++++++++++++ Drivers/Net/Pp2Dxe/Mvpp2Lib.h | 741 +++++ Drivers/Net/Pp2Dxe/Mvpp2LibHw.h | 1987 +++++++++++ Drivers/Net/Pp2Dxe/Pp2Dxe.c | 1280 +++++++ Drivers/Net/Pp2Dxe/Pp2Dxe.h | 455 +++ Drivers/Net/Pp2Dxe/Pp2Dxe.inf | 94 + Platforms/Marvell/Armada/Armada.dsc.inc | 1 + Platforms/Marvell/Armada/Armada70x0.dsc | 21 +- Platforms/Marvell/Armada/Armada70x0.fdf | 1 + Platforms/Marvell/Marvell.dec | 19 + 11 files changed, 9613 insertions(+), 1 deletion(-) create mode 100644 Documentation/Marvell/PortingGuide/Pp2.txt create mode 100644 Drivers/Net/Pp2Dxe/Mvpp2Lib.c create mode 100644 Drivers/Net/Pp2Dxe/Mvpp2Lib.h create mode 100644 Drivers/Net/Pp2Dxe/Mvpp2LibHw.h create mode 100644 Drivers/Net/Pp2Dxe/Pp2Dxe.c create mode 100644 Drivers/Net/Pp2Dxe/Pp2Dxe.h create mode 100644 Drivers/Net/Pp2Dxe/Pp2Dxe.inf