Re: [Linaro-uefi] [PATCH v8 6/6] Drivers/Net/MarvellYukon: Free link if its DMA buffer can't be allocated

On 30 August 2016 at 17:04, Alan Ott alan@softiron.co.uk wrote:

msk_rxeof() allocates a link object which contains a buffer. If the buffer can't be allocated, make sure to free the link object.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Alan Ott alan@softiron.co.uk

Reviewed-by: Ard Biesheuvel ard.biesheuvel@linaro.org

---

Drivers/Net/MarvellYukonDxe/if_msk.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/Drivers/Net/MarvellYukonDxe/if_msk.c b/Drivers/Net/MarvellYukonDxe/if_msk.c index 126cef5..2fbb096 100644 --- a/Drivers/Net/MarvellYukonDxe/if_msk.c +++ b/Drivers/Net/MarvellYukonDxe/if_msk.c @@ -1942,6 +1942,7 @@ msk_rxeof ( InsertTailList (&mSoftc->ReceiveQueueHead, &m_link->Link); } else { DEBUG ((EFI_D_NET, "Marvell Yukon: failed to allocate DMA buffer. Dropping Frame\n"));

•    gBS->FreePool (m_link);
   }
  

  } else { DEBUG ((EFI_D_NET, "Marvell Yukon: failed to allocate receive buffer link. Dropping Frame\n"));

-- 2.5.0