Thanks Jeremy, this looks good to me.
I have one comment on (EDK2) 2/3 and a minor one on (OpenPlatformPkg) 2/3. As I said in the comment, I would be happy to fix the EDK2 one on commit if you're happy with the proposed change?
For OpenPlatformPkg, I think these three patches can be folded into one (since the library is restricted to Juno anyway). Could you do this, to make sure the commit message is coherent?
Regards,
Leif
On Wed, Jul 27, 2016 at 02:24:33PM -0500, Jeremy Linton wrote:
v3-v4: Rebase/Split patch for newer edk2/OpenPlatformPkg v2-v3: Add JunoR2 support, replace CPU MIDR code with board revision detection v1->v2: General cleanups, move juno revision macro info platform.h
SMBIOS data is consumed by a wide range of enterprise applications.
Fill in the basic requirements of the SMBIOS specification by hardcoding the minimum required structures and data using Juno information. With this change both the EFI shell, BDS and linux dmidecode commands return useful information.
This patch set is actually against both edk2 and OpenPlatformPkg. The first three patches apply against edk2, the last three against OpenPlatformPkg.
Jeremy Linton (3): ArmPlatformPkg: Add A72 CPU type Code to detect what juno revision we are running on. Convert ArmJunoDxe to use common juno revision code Jeremy Linton (3): Platforms/ARM/Juno: Create SMBIOS/DMI data for Juno Platforms/ARM/Juno: Add the module build information Platforms/ARM/Juno: Add the SMBIOS/DMI module to the Juno Platform
ArmPkg/Include/Chipset/AArch64.h | 1 + .../ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 62 +++++++--------------- ArmPlatformPkg/ArmJunoPkg/Include/ArmPlatform.h | 30 ++++++++++- 3 files changed, 48 insertions(+), 45 deletions(-) Platforms/ARM/Juno/ArmJuno.dsc | 12 + Platforms/ARM/Juno/ArmJuno.fdf | 6 + .../ARM/Juno/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 864 +++++++++++++++++++++ .../Juno/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 68 ++ 4 files changed, 950 insertions(+) create mode 100644 Platforms/ARM/Juno/SmbiosPlatformDxe/SmbiosPlatformDxe.c create mode 100644 Platforms/ARM/Juno/SmbiosPlatformDxe/SmbiosPlatformDxe.inf
-- 2.5.5