25 Oct
2016
25 Oct
'16
12:54 p.m.
Hi Leif,
Thank you for review.
- gMarvellTokenSpaceGuid.PcdPp2MacAddressPort0|{ 0x0a, 0x70, 0x40, 0x00, 0x00, 0x1 }
- gMarvellTokenSpaceGuid.PcdPp2MacAddressPort1|{ 0x0a, 0x70, 0x40, 0x00, 0x00, 0x2 }
- gMarvellTokenSpaceGuid.PcdPp2MacAddressPort2|{ 0x0a, 0x70, 0x40, 0x00, 0x00, 0x3 }
I'm really not a fan of hard-wired MAC addresses. While clearly I should have commented on that for 2/3, it didn't jump out at me. Can you make sure to put it behind an explicit build-time define called ENABLE_FALLBACK_MAC_ADDRESSES?
This was explicitly added feature to let MAC address be defined in dedicated PCD's, please see function: Pp2DxeConfigureMacAddress(). I'd prefer it to stay as-is, but if you insist, I'll remove it and set MAC as in the 'default' fallback of the function's switch-case. Please let know.
Best regards, Marcin