Re: [Linaro-uefi] [PATCH v8 5/6] Drivers/Net/MarvellYukon: Set Dual Address Cycle Attribute

On 30 August 2016 at 17:04, Alan Ott alan@softiron.co.uk wrote:

The Dual Address Cycle Attribute is necessary for bus mastering PCI devices which are capable of generating 64-bit addresses. See the "Driver Writer's Guide for UEFI 2.3.1" version 1.01, section 18.3.2.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Alan Ott alan@softiron.co.uk

Reviewed-by: Ard Biesheuvel ard.biesheuvel@linaro.org

---

Drivers/Net/MarvellYukonDxe/if_msk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Drivers/Net/MarvellYukonDxe/if_msk.c b/Drivers/Net/MarvellYukonDxe/if_msk.c index eedf717..126cef5 100644 --- a/Drivers/Net/MarvellYukonDxe/if_msk.c +++ b/Drivers/Net/MarvellYukonDxe/if_msk.c @@ -1160,7 +1160,7 @@ mskc_attach ( Status = mPciIo->Attributes ( mPciIo, EfiPciIoAttributeOperationEnable,

•      Supports,
  

•      Supports | EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE,
       NULL
       );
  

  }

-- 2.5.0