linaro-validation February 2012

linaro-validation@lists.linaro.org

25 participants
36 discussions

Re: [Linaro-validation] code review: lava android benchmark code

by Zygmunt Krynicki

On 02/02/2012 05:30 PM, Andy Doan wrote: > Starting a new thread to deal with this project. > > We now have this project hosted at: > > > <http://android.git.linaro.org/gitweb?p=lava-server/android_benchmark_views.…> > > I've made a number of improvements since this was initially sent out > including: Hi Andy. I'm reading the code now. I have some comments. Essentially before this lands you _have_ to add one change, then we can follow up with iterative improvements. You _have_ to apply south migrations to your application. Without that we will not be able to make reasonable upgrades. Adding migrations later is not an option as there is a bit that is very hard to automate. Fortunately this is pretty easy: 1) Add a dependency on south (install_requires in setup.py) 2) Run lava-server manage ... android_benchmark_views_app schemamigration --initial --auto 3) Inspect the code briefly and add it to version control 4) Push that up for review. As for the rest: *) helpers.py, don't use double leading underscore. *) Try keeping the code that relates to your model in the model class, also add a few one liners if you can to document each public method *) extension.py, in def version(), pass the second argument to versiontools.format_version() please pass your main package object (android_benchmark_views_app). This will make it follow git version hashes. *) models.py, BenchmarkRun, each ForeignKey should have a related_name. This name is used when accessing the model field from the "remote" end, then you can navigate back using this name. In general this is required in some cases (when there are clashes, anyway this is beyond the scope of this conversation) *) models.py BenchmarkReport, don't use comments like that. Firs of all, in django it's very very bad to use nullable text/char fields. Instead always use null=False, blank=True - that makes writing code then saner. As for comments. Instead of using a simple text field please consider using django comment system. It _is_ slightly more complicated than using a free-for-all text area (like on launchpad's whiteboard but at the same time you get much more in return. You can read about this here: https://docs.djangoproject.com/en/dev/ref/contrib/comments/ *) models.py both classes, add a get_absolute_url() method based on django permalink system. It's trivial to use, see this document: https://docs.djangoproject.com/en/dev/ref/models/instances/#django.db.model… *) You ship query.flot. While that's okay for now I'd rather see this managed by a dedicated django app that just wraps this in one place. As for now this can stay as-is. *) Your templates extend dashboard templates. Please don't do that (as those templates are not a stable/public interface). Instead extend lava-server templates that work just as well but are stable. That's a very quick review. I have one more comment. EXCELLENT WORK :-) Could you please join the validation team? :-) Thanks ZK > > * general improvements to the flot library for rendering things > * zoom support for graphs > * DB queries > > The DB queries is the main thing Zygmunt complained about from the > initial code. I now hit the DB with one query to get all the > measurements I need it and let it perform the StdDev/Avg[1] > calculations. The performance (at least on my laptop) seems pretty good > now. The DB query improvement also allowed me to get rid of some ugly code. > > I'm hoping going forward I can start doing submissions as code reviews > in Gerrit and have someone on this team look at each change. > > Let me know what you think - or we can always sit down and chat about it > directly next week. > > [1]: NOTE: StdDev/Avg functions aren't supported by Sqlite3, so this > feature only works with postgres/mysql. > > -andy -- Zygmunt Krynicki Linaro Validation Team

12 years, 3 months

Bootstrap UI?

by Zygmunt Krynicki

Hi folks. I've noticed bootstrap [1] and it seems quite interesting as a UI toolkit. It seems more featureful and consistent than jQuery UI. Perhaps this is something to look at when we need to build/rebuild UI elements. Best regards ZK [1]: http://twitter.github.com/bootstrap/

12 years, 3 months

Validation at the Linaro Connect

by Paul Larson

Interested in Validation and going to the Linaro connect? Here are some of the sessions already scheduled that you might be interested in on the Validation track: Automated bootloader testing in LAVA https://blueprints.launchpad.net/lava-dispatcher/+spec/linaro-validation-q1… Discuss what needs to be done still on celery, and usage https://blueprints.launchpad.net/lava-lab/+spec/linaro-validation-q112-lava… LAVA Server Admin tools https://blueprints.launchpad.net/lava-server/+spec/linaro-validation-q112-a… Discuss test plans for big.LITTLE https://blueprints.launchpad.net/lava-test/+spec/linaro-validation-q112-big… Monitoring and managing device health in LAVA https://blueprints.launchpad.net/lava-lab/+spec/linaro-validation-q112-devi… Additionally, here are some sessions in other tracks that you may like: Ubuntu LEB and LAVA: Current status and future planning for proper image testing and validation https://blueprints.launchpad.net/linaro-ubuntu/+spec/linaro-platforms-q112-… Linaro's Kernel CI Process discussion and Feedback https://blueprints.launchpad.net/linaro/+spec/linaro-kernel-ci-q112-discuss… End to End Demo of Enabling Something for LAVA https://blueprints.launchpad.net/linaro/+spec/linaro-training-q112-end-to-e… Make sure to check http://summit.linaro.org/lcq1-12/track/linaro-validation/throughout the week for changes and additions. If you are around in the afternoons and want to help out on LAVA development, or want help getting started in it, swing by the validation hacking sessions and talk to us. See you next week!

12 years, 3 months

Connect session: Celery

by Paul Larson

https://blueprints.launchpad.net/lava-lab/+spec/linaro-validation-q112-lava… Please fill in if you have some ideas here. Hopefully zyga will be able to participate remotely in this as I'm sure he'll have some input.

12 years, 3 months

board state logging

by Paul Larson

I had a request today to produce some information about how long each board spends running jobs, idling, or offline as percentages for the past month, quarter, etc. This will be even more useful as we start doing things like offlining boards automatically when there is a problem. https://blueprints.launchpad.net/lava-scheduler/+spec/lava-board-state-logg… I know it won't be feasible to get historical data for offlinined boards, but I'd like if we could make it possible from this point forward. So this might be a good thing to try to get done during the hacking sessions this week. Thanks, Paul Larson

12 years, 3 months

code review: lava android benchmark code

by Fathi Boudra

---------- Forwarded message ---------- From: Andy Doan Date: 2 February 2012 18:30 Subject: code review: lava android benchmark code Starting a new thread to deal with this project. We now have this project hosted at: <http://android.git.linaro.org/gitweb?p=lava-server/android_benchmark_views.…> I've made a number of improvements since this was initially sent out including: * general improvements to the flot library for rendering things * zoom support for graphs * DB queries The DB queries is the main thing Zygmunt complained about from the initial code. I now hit the DB with one query to get all the measurements I need it and let it perform the StdDev/Avg[1] calculations. The performance (at least on my laptop) seems pretty good now. The DB query improvement also allowed me to get rid of some ugly code. I'm hoping going forward I can start doing submissions as code reviews in Gerrit and have someone on this team look at each change. Let me know what you think - or we can always sit down and chat about it directly next week. [1]: NOTE: StdDev/Avg functions aren't supported by Sqlite3, so this feature only works with postgres/mysql. -andy -- Fathi Boudra Linaro Release Manager | Validation Project Manager Linaro.org | Open source software for ARM SoCs

12 years, 3 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

linaro-validation February 2012