---------- Forwarded message ---------- From: Andy Doan Date: 2 February 2012 18:30 Subject: code review: lava android benchmark code

Starting a new thread to deal with this project.

We now have this project hosted at:

http://android.git.linaro.org/gitweb?p=lava-server/android_benchmark_views.git;a=summary

I've made a number of improvements since this was initially sent out including:

* general improvements to the flot library for rendering things  * zoom support for graphs  * DB queries

The DB queries is the main thing Zygmunt complained about from the initial code. I now hit the DB with one query to get all the measurements I need it and let it perform the StdDev/Avg[1] calculations. The performance (at least on my laptop) seems pretty good now. The DB query improvement also allowed me to get rid of some ugly code.

I'm hoping going forward I can start doing submissions as code reviews in Gerrit and have someone on this team look at each change.

Let me know what you think - or we can always sit down and chat about it directly next week.

[1]: NOTE: StdDev/Avg functions aren't supported by Sqlite3, so this feature only works with postgres/mysql.

-andy