Hi,
I made a small modification to lava-scheduler app code that enabled direct linking to line numbers in full log view. The branch was posted to launchpad: http://bazaar.launchpad.net/~mwasilew/lava-scheduler/log_linenumbers/revisio...
The solution isn't perfect as it hardcodes HTML tags into django templatetag, but I wanted minimal changes in the scheduler app code.
If you like it I will request the merge :)
Best Regards, milosz
Hi Milosz,
On 30 July 2013 13:49, Milosz Wasilewski milosz.wasilewski@linaro.org wrote:
Hi,
I made a small modification to lava-scheduler app code that enabled direct linking to line numbers in full log view. The branch was posted to launchpad: http://bazaar.launchpad.net/~mwasilew/lava-scheduler/log_linenumbers/revisio...
The solution isn't perfect as it hardcodes HTML tags into django templatetag, but I wanted minimal changes in the scheduler app code.
If you like it I will request the merge :)
I would love to see my feature request implemented: https://bugs.launchpad.net/lava-scheduler/+bug/1089800
Cheers, Fathi
On 30 July 2013 13:37, Fathi Boudra fathi.boudra@linaro.org wrote:
Hi Milosz,
On 30 July 2013 13:49, Milosz Wasilewski milosz.wasilewski@linaro.org wrote:
Hi,
I made a small modification to lava-scheduler app code that enabled direct linking to line numbers in full log view. The branch was posted to launchpad: http://bazaar.launchpad.net/~mwasilew/lava-scheduler/log_linenumbers/revisio...
The solution isn't perfect as it hardcodes HTML tags into django templatetag, but I wanted minimal changes in the scheduler app code.
If you like it I will request the merge :)
I would love to see my feature request implemented: https://bugs.launchpad.net/lava-scheduler/+bug/1089800
The hard part is to filter the log file to find the 'valuable' output. If someone from LAVA team has idea how to do it, I can provide the patch. At the moment there are 3 categories of log lines: log, console, traceback. LAVA doesn't distinguish between master and testing images unfortunately. The UI part doesn't seem to be very difficult. With line numbers you can at least get the URL that points to the right place in the view.
milosz
Hi Milosz,
On Tue, Jul 30, 2013 at 11:49:59AM +0100, Milosz Wasilewski wrote:
Hi,
I made a small modification to lava-scheduler app code that enabled direct linking to line numbers in full log view. The branch was posted to launchpad: http://bazaar.launchpad.net/~mwasilew/lava-scheduler/log_linenumbers/revisio...
The solution isn't perfect as it hardcodes HTML tags into django templatetag, but I wanted minimal changes in the scheduler app code.
If you like it I will request the merge :)
independent of whether we already like it or not, please request the merge. We'll review the patch in the merge proposal, and let you know what needs to be fixed if anything. :)
Milosz Wasilewski milosz.wasilewski@linaro.org writes:
On 30 July 2013 13:37, Fathi Boudra fathi.boudra@linaro.org wrote:
Hi Milosz,
On 30 July 2013 13:49, Milosz Wasilewski milosz.wasilewski@linaro.org wrote:
Hi,
I made a small modification to lava-scheduler app code that enabled direct linking to line numbers in full log view. The branch was posted to launchpad: http://bazaar.launchpad.net/~mwasilew/lava-scheduler/log_linenumbers/revisio...
The solution isn't perfect as it hardcodes HTML tags into django templatetag, but I wanted minimal changes in the scheduler app code.
If you like it I will request the merge :)
I would love to see my feature request implemented: https://bugs.launchpad.net/lava-scheduler/+bug/1089800
The hard part is to filter the log file to find the 'valuable' output. If someone from LAVA team has idea how to do it, I can provide the patch. At the moment there are 3 categories of log lines: log, console, traceback. LAVA doesn't distinguish between master and testing images unfortunately. The UI part doesn't seem to be very difficult. With line numbers you can at least get the URL that points to the right place in the view.
There is some plumbing in the dispatcher to send output to different places (look at Outputter in context.py). My idea that I never got around to implementing was that instead of just dumping output into a file, it would be some kind of structured output that tagged each line somehow and then the scheduler webapp would interpret this data. Have fun :-)
Cheers, mwh
Hello,
On Tue, 30 Jul 2013 10:48:53 -0300 Antonio Terceiro antonio.terceiro@linaro.org wrote:
Hi Milosz,
On Tue, Jul 30, 2013 at 11:49:59AM +0100, Milosz Wasilewski wrote:
Hi,
I made a small modification to lava-scheduler app code that enabled direct linking to line numbers in full log view. The branch was posted to launchpad: http://bazaar.launchpad.net/~mwasilew/lava-scheduler/log_linenumbers/revisio...
The solution isn't perfect as it hardcodes HTML tags into django templatetag, but I wanted minimal changes in the scheduler app code.
If you like it I will request the merge :)
independent of whether we already like it or not, please request the merge. We'll review the patch in the merge proposal, and let you know what needs to be fixed if anything. :)
But we definitely like the functionally offered and overall discussion which ensued on improving LAVA log view - it's indeed too cumbersome too deal with LAVA logs now. The rule of thumb I reduced to is that if I don't have at least half-day to spend on debugging LAVA job issues, then it's better not to poke at it at all, because an hour can be gone and little figured out (times of course include trying fixes and waiting for job re-runs).
linaro-validation@lists.linaro.org
-
Antonio Terceiro -
Fathi Boudra -
Michael Hudson-Doyle -
Milosz Wasilewski -
Paul Sokolovsky