Hi Vishal,

Skia.sh is not been placed yet in the repository (shoulde be placed @ android/scripts/skia.sh) I think, the results will be populated once, it is placed here. Correct me, If I am wrong.

Thanks and Regards, HariGopal

On 28 March 2013 13:19, Vishal Bhoj vishal.bhoj@linaro.org wrote:

Hi Hari,

I don't see any measurement values getting populated in results:

https://validation.linaro.org/lava-server/dashboard/streams/anonymous/styles...

Here are the reference results from skia run from lava-android-test:

http://validation.linaro.org/lava-server/dashboard/streams/private/team/lina...

On 28 March 2013 13:12, Harigopal Gollamudi < harigopal.gollamudi@linaro.org> wrote:

...

Dear validation team,

Please find the patch code for Skia test, kindly review this and provide me the feedback.

Skia.yaml pattern has been verified through validation server @ https://validation.linaro.org/lava-server/scheduler/job/50406

-- Thanks and Regards, HariGopal G Android Engineer

Hi Senthil,

In python script for Skia, the test results are hardcoded to 'pass'. It is populating only the measurements.

====================================== data['test_case_id'] = "%s_%s" % (test,

match.group('type')) data['measurement'] = match.group('time') data['result'] = 'pass' data['units'] = 'ms' data['log_filename'] = result_filename

self.results['test_results'].append(data) ======================================

Thanks and Regards, HariGopal G

On 28 March 2013 13:23, Senthil Kumaran senthil.kumaran@linaro.org wrote:

Hi Hari,

On Thu, 2013-03-28 at 13:12 +0530, Harigopal Gollamudi wrote:

...

Please find the patch code for Skia test, kindly review this and provide me the feedback.

I haven't reviewed the patch yet.

...

Skia.yaml pattern has been verified through validation server @ https://validation.linaro.org/lava-server/scheduler/job/50406

But looking at https://validation.linaro.org/lava-server/dashboard/attachment/265900/view

and

https://validation.linaro.org/lava-server/dashboard/streams/anonymous/styles...

I could see the test results are wrong. There is no pass/fail reported on the bundle. Secondly, the shell script did not run.

Thank You.

-- Senthil Kumaran http://www.stylesen.org/ http://www.sasenthilkumaran.com/