On 2 November 2017 at 14:00, Naresh Kamboju naresh.kamboju@linaro.org wrote:

Hi Lei,

On 1 November 2017 at 19:39, lyang0 lei.yang@windriver.com wrote:

...

Hi,

I'm using a job definition template to submit lava jobs, basically, I use something like

path: automated/linux/{test_suite}/{test_suite}.yaml

We use relative path directly. What is the benefits in using a variable here? Can you share your whole job template?

...

but I find that lmbench it doesn't use this template.

lmbench-memory is part of lmbench. We could have more then one sub-tests in the same folder, or more then one yaml files using the same script, but with different params and slightly different file name. It is not just lmbench. There are more tests like this(about 6 tests). It is fine to use a separate test folder for each sub-test like ltp-realtime does, but you cannot assume test case writer always uses the same name for both test folder and file names, in most case, yes, but not always.

...

can I send a patch to rename "automated/linux/lmbench/

lmbench-memory.yaml"

...

to "automated/linux/lmbench-memory/lmbench-memory.yaml "

This change will break our(or other teams') existing test job templates and test plans. Please share your use case, lets see it is worth to do so.

Thanks, Chase

Please send a patch. Our team will review.

• Naresh

...

just like ltp-realtime does

lyang001@pek-lyang0-d1:/tmp/tt/test-definitions$ ls automated/linux/ltp-realtime/ltp-realtime.yaml automated/linux/ltp-realtime/ltp-realtime.yaml

Lei

On 2 November 2017 at 15:52, lyang0 lei.yang@windriver.com wrote:

On 2017年11月02日 15:28, Chase Qi wrote:

On 2 November 2017 at 14:00, Naresh Kamboju naresh.kamboju@linaro.org wrote:

...

Hi Lei,

On 1 November 2017 at 19:39, lyang0 lei.yang@windriver.com wrote:

...

Hi,

I'm using a job definition template to submit lava jobs, basically, I use something like

path: automated/linux/{test_suite}/{test_suite}.yaml

We use relative path directly. What is the benefits in using a variable here? Can you share your whole job template?

I use

• test: timeout: minutes: 100 definitions:
  • repository: https://git.linaro.org/qa/test-definitions.git from: git path: automated/linux/{test_suite}/{test_suite}.yaml name: test parameters: DEVICE: /dev/sda PARTITION: /dev/sda1 SKIP_INSTALL: true skip_install: - deps

Ok, I'm fine with not changing anything. I can use a dictionary to fix the value

Great! Thanks for your understanding!

Lei

...

...

but I find that lmbench it doesn't use this template.

lmbench-memory is part of lmbench. We could have more then one sub-tests in the same folder, or more then one yaml files using the same script, but with different params and slightly different file name. It is not just lmbench. There are more tests like this(about 6 tests). It is fine to use a separate test folder for each sub-test like ltp-realtime does, but you cannot assume test case writer always uses the same name for both test folder and file names, in most case, yes, but not always.

...

...

can I send a patch to rename "automated/linux/lmbench/lmbench-memory.yaml"

to "automated/linux/lmbench-memory/lmbench-memory.yaml "

This change will break our(or other teams') existing test job templates and test plans. Please share your use case, lets see it is worth to do so.

Thanks, Chase

...

Please send a patch. Our team will review.

• Naresh

...

just like ltp-realtime does

lyang001@pek-lyang0-d1:/tmp/tt/test-definitions$ ls automated/linux/ltp-realtime/ltp-realtime.yaml automated/linux/ltp-realtime/ltp-realtime.yaml

Lei