On 30/06/2022 14:16, Hans Schultz wrote:

This patch is related to the patch set "Add support for locked bridge ports (for 802.1X)" Link: https://lore.kernel.org/netdev/20220223101650.1212814-1-schultz.hans+netdev@...

This patch makes the locked port feature work with learning turned on, which is enabled with the command:

bridge link set dev DEV learning on

Without this patch, link local traffic (01:80:c2) like EAPOL packets will create a fdb entry when ingressing on a locked port with learning turned on, thus unintentionally opening up the port for traffic for the said MAC.

Some switchcore features like Mac-Auth and refreshing of FDB entries, require learning enables on some switchcores, f.ex. the mv88e6xxx family. Other features may apply too.

Since many switchcores trap or mirror various multicast packets to the CPU, link local traffic will unintentionally unlock the port for the SA mac in question unless prevented by this patch.

Signed-off-by: Hans Schultz hans@kapio-technology.com

net/bridge/br_input.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c index 68b3e850bcb9..a3ce0a151817 100644 --- a/net/bridge/br_input.c +++ b/net/bridge/br_input.c @@ -215,6 +215,7 @@ static void __br_handle_local_finish(struct sk_buff *skb) if ((p->flags & BR_LEARNING) && nbp_state_should_learn(p) && !br_opt_get(p->br, BROPT_NO_LL_LEARN) &&

•    !(p->flags & BR_PORT_LOCKED) &&
   br_should_learn(p, skb, &vid))
  

  br_fdb_update(p->br, p, eth_hdr(skb)->h_source, vid, 0);

}

LGTM, thanks! Acked-by: Nikolay Aleksandrov razor@blackwall.org