The previous patch tries to include a arch check for powerpc using findstring, which prevents test from building on powerpc arch. Fix this with filtering using machine type.
Signed-off-by: Harish harish@linux.ibm.com --- tools/testing/selftests/vm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile index 691893afc15d..0dc632cdbc73 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -61,7 +61,7 @@ TEST_GEN_FILES += $(BINARIES_64) endif else
-ifneq (,$(findstring $(ARCH),powerpc)) +ifneq (,$(filter $(MACHINE),ppc64 ppc64le)) TEST_GEN_FILES += protection_keys endif
On Mon, 14 Dec 2020 22:09:51 +0530 Harish harish@linux.ibm.com wrote:
The previous patch
d8cbe8bfa7d ("tools/testing/selftests/vm: fix build error"), yes?
tries to include a arch check for powerpc using findstring, which prevents test from building on powerpc arch.
Why is that? Please describe the error fully. Presumably by pasting the error messages?
Fix this with filtering using machine type.
How does this fix whatever-the-problem-was?
Presumably the 5.10 build fails under some circumstances, yes? In which case a Fixes: line and a cc:stable@vger.kernel.org are needed.
Signed-off-by: Harish harish@linux.ibm.com
tools/testing/selftests/vm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile index 691893afc15d..0dc632cdbc73 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -61,7 +61,7 @@ TEST_GEN_FILES += $(BINARIES_64) endif else -ifneq (,$(findstring $(ARCH),powerpc)) +ifneq (,$(filter $(MACHINE),ppc64 ppc64le)) TEST_GEN_FILES += protection_keys endif -- 2.26.2
linux-kselftest-mirror@lists.linaro.org
-
Andrew Morton -
Harish