On 11/28/22 15:53, Maxime Ripard wrote:

The current helper to allocate a DRM device doesn't allow for any subclassing by drivers, which is going to be troublesome as we work on getting some kunit testing on atomic modesetting code.

Let's use a similar pattern to the other allocation helpers by providing the structure size and offset as arguments.

Signed-off-by: Maxime Ripard maxime@cerno.tech

[...]

-EXPORT_SYMBOL(drm_kunit_helper_alloc_drm_device); +EXPORT_SYMBOL(__drm_kunit_helper_alloc_drm_device);

I'm not sure if I would add a __ prefix to exported symbols, but I see that this is a convention in the DRM subsystem so I'm OK with it.

Another thing that came to mind is if we want to use EXPORT_SYMBOL_GPL() instead for the DRM KUnit helpers. But that's not related to this series.

Reviewed-by: Javier Martinez Canillas javierm@redhat.com