On 12.04.23 12:45, Deming Wang wrote:

memalign() is obsolete according to its manpage.

Replace memalign() with posix_memalign()

As a pointer is passed into posix_memalign(), initialize *one_page to NULL to silence a warning about the function's return value being

Where is the initialization to NULL done below?

used as uninitialized (which is not valid anyway because the error is properly checked before p is returned).

"p" ?

Signed-off-by: Deming Wang wangdeming@inspur.com

tools/testing/selftests/mm/split_huge_page_test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c index cbb5e6893cbf..94c7dffc4d7d 100644 --- a/tools/testing/selftests/mm/split_huge_page_test.c +++ b/tools/testing/selftests/mm/split_huge_page_test.c @@ -96,10 +96,10 @@ void split_pmd_thp(void) char *one_page; size_t len = 4 * pmd_pagesize; size_t i;

• int ret;

• one_page = memalign(pmd_pagesize, len);
• if (!one_page) {

• ret = posix_memalign((void **)&one_page, pmd_pagesize, len);
• if (ret < 0) { printf("Fail to allocate memory\n"); exit(EXIT_FAILURE); }