Building and running the subsuite 'damon' of kselftest, shows the following issues: selftests: damon: debugfs_attrs.sh /sys/kernel/debug/damon not found
By creating a config file enabling DAMON fragments in the selftests/damon/ directory the tests pass.
Reported-by: Naresh Kamboju naresh.kamboju@linaro.org Signed-off-by: Anders Roxell anders.roxell@linaro.org --- tools/testing/selftests/damon/config | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 tools/testing/selftests/damon/config
diff --git a/tools/testing/selftests/damon/config b/tools/testing/selftests/damon/config new file mode 100644 index 000000000000..a6b636e438b9 --- /dev/null +++ b/tools/testing/selftests/damon/config @@ -0,0 +1,8 @@ +CONFIG_DEBUG_SYSFS=y +CONFIG_DAMON=y +CONFIG_DAMON_SYSFS=y +CONFIG_DAMON_DBGFS=y +CONFIG_DAMON_PADDR=y +CONFIG_DAMON_VADDR=y +CONFIG_DAMON_RECLAIM=y +CONFIG_DAMON_LRU_SORT=y
When running kselftest-damon The following issues shows up:
'# Warning: file debugfs_attrs.sh is not executable'
Changing the scripts so they are executable.
Signed-off-by: Anders Roxell anders.roxell@linaro.org --- tools/testing/selftests/damon/_chk_dependency.sh | 0 tools/testing/selftests/damon/_debugfs_common.sh | 0 tools/testing/selftests/damon/debugfs_attrs.sh | 0 .../testing/selftests/damon/debugfs_duplicate_context_creation.sh | 0 tools/testing/selftests/damon/debugfs_empty_targets.sh | 0 tools/testing/selftests/damon/debugfs_huge_count_read_write.sh | 0 tools/testing/selftests/damon/debugfs_rm_non_contexts.sh | 0 tools/testing/selftests/damon/debugfs_schemes.sh | 0 tools/testing/selftests/damon/debugfs_target_ids.sh | 0 tools/testing/selftests/damon/lru_sort.sh | 0 tools/testing/selftests/damon/reclaim.sh | 0 tools/testing/selftests/damon/sysfs.sh | 0 tools/testing/selftests/damon/sysfs_update_removed_scheme_dir.sh | 0 13 files changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tools/testing/selftests/damon/_chk_dependency.sh mode change 100644 => 100755 tools/testing/selftests/damon/_debugfs_common.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_attrs.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_duplicate_context_creation.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_empty_targets.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_huge_count_read_write.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_rm_non_contexts.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_schemes.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids.sh mode change 100644 => 100755 tools/testing/selftests/damon/lru_sort.sh mode change 100644 => 100755 tools/testing/selftests/damon/reclaim.sh mode change 100644 => 100755 tools/testing/selftests/damon/sysfs.sh mode change 100644 => 100755 tools/testing/selftests/damon/sysfs_update_removed_scheme_dir.sh
diff --git a/tools/testing/selftests/damon/_chk_dependency.sh b/tools/testing/selftests/damon/_chk_dependency.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/_debugfs_common.sh b/tools/testing/selftests/damon/_debugfs_common.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/debugfs_duplicate_context_creation.sh b/tools/testing/selftests/damon/debugfs_duplicate_context_creation.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/debugfs_empty_targets.sh b/tools/testing/selftests/damon/debugfs_empty_targets.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/debugfs_huge_count_read_write.sh b/tools/testing/selftests/damon/debugfs_huge_count_read_write.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/debugfs_rm_non_contexts.sh b/tools/testing/selftests/damon/debugfs_rm_non_contexts.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/debugfs_schemes.sh b/tools/testing/selftests/damon/debugfs_schemes.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/debugfs_target_ids.sh b/tools/testing/selftests/damon/debugfs_target_ids.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/lru_sort.sh b/tools/testing/selftests/damon/lru_sort.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/reclaim.sh b/tools/testing/selftests/damon/reclaim.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/sysfs.sh b/tools/testing/selftests/damon/sysfs.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/sysfs_update_removed_scheme_dir.sh b/tools/testing/selftests/damon/sysfs_update_removed_scheme_dir.sh old mode 100644 new mode 100755
On Tue, 21 Feb 2023 08:08:37 +0100 Anders Roxell anders.roxell@linaro.org wrote:
When running kselftest-damon The following issues shows up:
'# Warning: file debugfs_attrs.sh is not executable'
Changing the scripts so they are executable.
I tried to make similar changes before[1], but resulted in making a change in kselftest following Greg's comment[2]. So it might make sense to remove the warning message from kselftest instead of this change, though I think this change also looks good. Could I ask others' opinions?
[1] https://lore.kernel.org/mm-commits/20210810112050.22225-1-sj38.park@gmail.co... [2] https://lore.kernel.org/mm-commits/YRJisBs9AunccCD4@kroah.com/
Thanks, SJ
Signed-off-by: Anders Roxell anders.roxell@linaro.org
Hi Anders,
Thank you for this patch!
On Tue, 21 Feb 2023 08:08:36 +0100 Anders Roxell anders.roxell@linaro.org wrote:
Building and running the subsuite 'damon' of kselftest, shows the following issues: selftests: damon: debugfs_attrs.sh /sys/kernel/debug/damon not found
By creating a config file enabling DAMON fragments in the selftests/damon/ directory the tests pass.
I think we could put Fixes tag as below?
Fixes: b348eb7abd09 ("mm/damon: add user space selftests")
Though this may not need to be merged in stable.
Reported-by: Naresh Kamboju naresh.kamboju@linaro.org Signed-off-by: Anders Roxell anders.roxell@linaro.org
tools/testing/selftests/damon/config | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 tools/testing/selftests/damon/config
diff --git a/tools/testing/selftests/damon/config b/tools/testing/selftests/damon/config new file mode 100644 index 000000000000..a6b636e438b9 --- /dev/null +++ b/tools/testing/selftests/damon/config @@ -0,0 +1,8 @@ +CONFIG_DEBUG_SYSFS=y
's/SYS//'? Or, I guess this is not needed at all?
+CONFIG_DAMON=y +CONFIG_DAMON_SYSFS=y +CONFIG_DAMON_DBGFS=y +CONFIG_DAMON_PADDR=y +CONFIG_DAMON_VADDR=y +CONFIG_DAMON_RECLAIM=y +CONFIG_DAMON_LRU_SORT=y
Thanks, SJ
-- 2.39.1
On Tue, 21 Feb 2023 at 18:19, SeongJae Park sj@kernel.org wrote:
Hi Anders,
Thank you for this patch!
On Tue, 21 Feb 2023 08:08:36 +0100 Anders Roxell anders.roxell@linaro.org wrote:
Building and running the subsuite 'damon' of kselftest, shows the following issues: selftests: damon: debugfs_attrs.sh /sys/kernel/debug/damon not found
By creating a config file enabling DAMON fragments in the selftests/damon/ directory the tests pass.
I think we could put Fixes tag as below?
Fixes: b348eb7abd09 ("mm/damon: add user space selftests")
Make sense, I'll add it.
Though this may not need to be merged in stable.
Reported-by: Naresh Kamboju naresh.kamboju@linaro.org Signed-off-by: Anders Roxell anders.roxell@linaro.org
tools/testing/selftests/damon/config | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 tools/testing/selftests/damon/config
diff --git a/tools/testing/selftests/damon/config b/tools/testing/selftests/damon/config new file mode 100644 index 000000000000..a6b636e438b9 --- /dev/null +++ b/tools/testing/selftests/damon/config @@ -0,0 +1,8 @@ +CONFIG_DEBUG_SYSFS=y
's/SYS//'? Or, I guess this is not needed at all?
This can be dropped.
Thank you.
I'll respin the patch shortly.
Cheers, Anders
+CONFIG_DAMON=y +CONFIG_DAMON_SYSFS=y +CONFIG_DAMON_DBGFS=y +CONFIG_DAMON_PADDR=y +CONFIG_DAMON_VADDR=y +CONFIG_DAMON_RECLAIM=y +CONFIG_DAMON_LRU_SORT=y
Thanks, SJ
-- 2.39.1
linux-kselftest-mirror@lists.linaro.org
-
Anders Roxell -
SeongJae Park