From: Changcheng Deng deng.changcheng@zte.com.cn
Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element.
Reported-by: Zeal Robot zealci@zte.com.cn Signed-off-by: Changcheng Deng deng.changcheng@zte.com.cn --- tools/testing/selftests/kvm/x86_64/debug_regs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/kvm/x86_64/debug_regs.c b/tools/testing/selftests/kvm/x86_64/debug_regs.c index 5f078db1bcba..ef24ad62d36a 100644 --- a/tools/testing/selftests/kvm/x86_64/debug_regs.c +++ b/tools/testing/selftests/kvm/x86_64/debug_regs.c @@ -168,7 +168,7 @@ int main(void) target_rip = CAST_TO_RIP(ss_start); target_dr6 = 0xffff4ff0ULL; vcpu_regs_get(vm, VCPU_ID, ®s); - for (i = 0; i < (sizeof(ss_size) / sizeof(ss_size[0])); i++) { + for (i = 0; i < ARRAY_SIZE(ss_size); i++) { target_rip += ss_size[i]; CLEAR_DEBUG(); debug.control = KVM_GUESTDBG_ENABLE | KVM_GUESTDBG_SINGLESTEP |
On Wed, Nov 24, 2021 at 09:22:56AM +0000, cgel.zte@gmail.com wrote:
From: Changcheng Deng deng.changcheng@zte.com.cn
Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element.
Reported-by: Zeal Robot zealci@zte.com.cn Signed-off-by: Changcheng Deng deng.changcheng@zte.com.cn
Your email address does not match these here, you need to provide a signed-off-by as well.
And are you _SURE_ that you can use kernel #defines in userspace testing code?
thanks,
greg k-h
On 11/24/21 10:46, Greg KH wrote:
From: Changcheng Dengdeng.changcheng@zte.com.cn
Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element.
Reported-by: Zeal Robotzealci@zte.com.cn Signed-off-by: Changcheng Dengdeng.changcheng@zte.com.cn
Your email address does not match these here, you need to provide a signed-off-by as well.
And are you_SURE_ that you can use kernel #defines in userspace testing code?
Dpeends on which, but ARRAY_SIZE is among those that can be used:
$ git grep '#define ARRAY_SIZE' 'tools/*.h' tools/gpio/gpio-utils.h:#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) tools/iio/iio_utils.h:#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0])) tools/include/linux/kernel.h:#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) tools/testing/selftests/bpf/progs/profiler.inc.h:#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0])) tools/testing/selftests/cgroup/cgroup_util.h:#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) tools/testing/selftests/kselftest_harness.h:#define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0])) tools/testing/selftests/landlock/common.h:#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) tools/testing/selftests/vm/pkey-helpers.h:#define ARRAY_SIZE(x) (sizeof(x) / sizeof(*(x))) tools/virtio/linux/kernel.h:#define ARRAY_SIZE(x) (sizeof(x)/sizeof(x[0]))
In particular, most KVM tests already include linux/kernel.h indirectly via linux/list.h.
Paolo
linux-kselftest-mirror@lists.linaro.org
-
cgel.zte＠gmail.com -
Greg KH -
Paolo Bonzini