On Fri, Jan 6, 2023 at 2:42 PM kernel test robot lkp@intel.com wrote:

Hi Benjamin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on hid/for-next] [also build test WARNING on next-20230106] [cannot apply to shuah-kselftest/next shuah-kselftest/fixes char-misc/char-misc-testing char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.2-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Benjamin-Tissoires/selftests-... base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next patch link: https://lore.kernel.org/r/20230106102332.1019632-9-benjamin.tissoires%40redh... patch subject: [PATCH HID for-next v1 8/9] HID: bpf: clean up entrypoint config: i386-randconfig-a013 compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/46336953b47885c5111b7c1a92403b... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Benjamin-Tissoires/selftests-hid-add-vmtest-sh/20230106-182823 git checkout 46336953b47885c5111b7c1a92403b3d94cf3d41 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/hid/bpf/

If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot lkp@intel.com

All warnings (new ones prefixed by >>):

...

...

drivers/hid/bpf/hid_bpf_jmp_table.c:502:6: warning: no previous prototype for function 'call_hid_bpf_prog_put_deferred' [-Wmissing-prototypes]

void call_hid_bpf_prog_put_deferred(struct work_struct *work) ^ drivers/hid/bpf/hid_bpf_jmp_table.c:502:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void call_hid_bpf_prog_put_deferred(struct work_struct *work) ^ static 1 warning generated.

vim +/call_hid_bpf_prog_put_deferred +502 drivers/hid/bpf/hid_bpf_jmp_table.c

f5c27da4e3c8a2 Benjamin Tissoires 2022-11-03 501 0baef37335dd4d Benjamin Tissoires 2022-11-03 @502 void call_hid_bpf_prog_put_deferred(struct work_struct *work) f5c27da4e3c8a2 Benjamin Tissoires 2022-11-03 503 { ade9207f04dc40 Benjamin Tissoires 2023-01-06 504 /* kept around for patch readability, to be dropped in the next commmit */ f5c27da4e3c8a2 Benjamin Tissoires 2022-11-03 505 } f5c27da4e3c8a2 Benjamin Tissoires 2022-11-03 506

Oops, this function should have been dropped in 8/9 "HID: bpf: clean up entrypoint". It's now dead code. I'll fix it in v2.

Cheers, Benjamin

-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests