From: Shaoqin Huang shahuang@redhat.com
The parameter arg in guest_modes_cmdline not being used now, and the optarg should be replaced with arg in guest_modes_cmdline.
And this is the chance to change strtoul() to atoi_non_negative(), since guest mode ID will never be negative.
Signed-off-by: Shaoqin Huang shahuang@redhat.com
--- Changes from v1: - Change strtoul() to atoi_non_negative(). [Vipin]
--- tools/testing/selftests/kvm/lib/guest_modes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/kvm/lib/guest_modes.c b/tools/testing/selftests/kvm/lib/guest_modes.c index 99a575bbbc52..1df3ce4b16fd 100644 --- a/tools/testing/selftests/kvm/lib/guest_modes.c +++ b/tools/testing/selftests/kvm/lib/guest_modes.c @@ -127,7 +127,7 @@ void guest_modes_cmdline(const char *arg) mode_selected = true; }
- mode = strtoul(optarg, NULL, 10); + mode = atoi_non_negative("Guest mode ID", arg); TEST_ASSERT(mode < NUM_VM_MODES, "Guest mode ID %d too big", mode); guest_modes[mode].enabled = true; }
On Thu, Feb 02, 2023 at 10:57:15AM +0800, shahuang@redhat.com wrote:
From: Shaoqin Huang shahuang@redhat.com
The parameter arg in guest_modes_cmdline not being used now, and the optarg should be replaced with arg in guest_modes_cmdline.
And this is the chance to change strtoul() to atoi_non_negative(), since guest mode ID will never be negative.
Fixes: e42ac777d661 ("KVM: selftests: Factor out guest mode code")
Signed-off-by: Shaoqin Huang shahuang@redhat.com
Changes from v1:
- Change strtoul() to atoi_non_negative(). [Vipin]
tools/testing/selftests/kvm/lib/guest_modes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/kvm/lib/guest_modes.c b/tools/testing/selftests/kvm/lib/guest_modes.c index 99a575bbbc52..1df3ce4b16fd 100644 --- a/tools/testing/selftests/kvm/lib/guest_modes.c +++ b/tools/testing/selftests/kvm/lib/guest_modes.c @@ -127,7 +127,7 @@ void guest_modes_cmdline(const char *arg) mode_selected = true; }
- mode = strtoul(optarg, NULL, 10);
- mode = atoi_non_negative("Guest mode ID", arg); TEST_ASSERT(mode < NUM_VM_MODES, "Guest mode ID %d too big", mode); guest_modes[mode].enabled = true;
}
2.39.0
Reviewed-by: Andrew Jones andrew.jones@linux.dev
On Thu, Feb 2, 2023 at 12:11 AM Andrew Jones andrew.jones@linux.dev wrote:
On Thu, Feb 02, 2023 at 10:57:15AM +0800, shahuang@redhat.com wrote:
From: Shaoqin Huang shahuang@redhat.com
The parameter arg in guest_modes_cmdline not being used now, and the optarg should be replaced with arg in guest_modes_cmdline.
And this is the chance to change strtoul() to atoi_non_negative(), since guest mode ID will never be negative.
Fixes: e42ac777d661 ("KVM: selftests: Factor out guest mode code")
Signed-off-by: Shaoqin Huang shahuang@redhat.com
Changes from v1:
- Change strtoul() to atoi_non_negative(). [Vipin]
tools/testing/selftests/kvm/lib/guest_modes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/kvm/lib/guest_modes.c b/tools/testing/selftests/kvm/lib/guest_modes.c index 99a575bbbc52..1df3ce4b16fd 100644 --- a/tools/testing/selftests/kvm/lib/guest_modes.c +++ b/tools/testing/selftests/kvm/lib/guest_modes.c @@ -127,7 +127,7 @@ void guest_modes_cmdline(const char *arg) mode_selected = true; }
mode = strtoul(optarg, NULL, 10);
mode = atoi_non_negative("Guest mode ID", arg); TEST_ASSERT(mode < NUM_VM_MODES, "Guest mode ID %d too big", mode); guest_modes[mode].enabled = true;}
2.39.0
Reviewed-by: Andrew Jones andrew.jones@linux.dev
Reviewed-by: Vipin Sharma vipinsh@google.com
On Thu, 02 Feb 2023 10:57:15 +0800, shahuang@redhat.com wrote:
The parameter arg in guest_modes_cmdline not being used now, and the optarg should be replaced with arg in guest_modes_cmdline.
And this is the chance to change strtoul() to atoi_non_negative(), since guest mode ID will never be negative.
[...]
Applied to kvm-x86 selftests, thanks!
[1/1] selftests: KVM: Replace optarg with arg in guest_modes_cmdline https://github.com/kvm-x86/linux/commit/62f86202d76d
-- https://github.com/kvm-x86/linux/tree/next https://github.com/kvm-x86/linux/tree/fixes
On Wed, Feb 08, 2023, Sean Christopherson wrote:
On Thu, 02 Feb 2023 10:57:15 +0800, shahuang@redhat.com wrote:
The parameter arg in guest_modes_cmdline not being used now, and the optarg should be replaced with arg in guest_modes_cmdline.
And this is the chance to change strtoul() to atoi_non_negative(), since guest mode ID will never be negative.
[...]
Applied to kvm-x86 selftests, thanks!
[1/1] selftests: KVM: Replace optarg with arg in guest_modes_cmdline https://github.com/kvm-x86/linux/commit/62f86202d76d
I force pushed to selftests because of a goof on my end, new SHA-1 is:
linux-kselftest-mirror@lists.linaro.org
-
Andrew Jones -
Sean Christopherson -
shahuang＠redhat.com -
Vipin Sharma