On 10/14/22 18:37, Arnd Bergmann wrote:
On Fri, Oct 14, 2022, at 11:22 AM, Anders Roxell wrote:
On Fri, 14 Oct 2022 at 09:53, Damien Le Moal
Tested this patch on todays linux-next tag: next-20221014 without enabling CONFIG_AHCI_DWC and it worked as expected when booting [1]. On the other hand I also tried a build/boot with CONFIG_AHCI_DWC enabled and it worked as expected to boot [2].
That is great news ! So the new driver is OK, good !
Ok, great. Can you a patch to soc@kernel.org to enable the driver in the relevant defconfigs?
However, during building a warning [3] popped up:
make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/2/build ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc' /builds/linux/drivers/ata/ahci_dwc.c:462:34: warning: 'ahci_dwc_plat' defined but not used [-Wunused-variable] 462 | static struct ahci_dwc_plat_data ahci_dwc_plat = {
Strange, I can't reproduce this, and the ahci_dwc_plat symbol looks like it is clearly used in ahci_dwc_of_match[], at least in next-20221014. Do you also see this on mainline?
This is with the trial fix diff I sent. My bad, it was not even compile tested :). Does not happen otherwise.
Arnd
Thanks for helping with this !