On Wed, Jun 28, 2023 at 01:38:50PM -0700, Jakub Kicinski wrote:
On Wed, 28 Jun 2023 03:16:43 +0200 Andrew Lunn wrote:
- } else if (attr == &dev_attr_max_phase_adjustment.attr) {
if (!info->adjphase || !info->getmaxphase)
mode = 0;
Maybe it is time to turn this into a switch statement?
I don't think we can switch on pointers in C.
https://elixir.bootlin.com/linux/latest/source/drivers/net/phy/sfp.c#L749
Works for temperature sensors, voltage sensors, current sensors, and power sensors. Maybe hwmon is different to what is going on here, but both a sysfs files.
The patch is good as is, right?
Yes.
Reviewed-by: Andrew Lunn andrew@lunn.ch
Andrew