greybus-dev May 2021

greybus-dev@lists.linaro.org

17 participants
17 discussions

by Anuj Deshpande

Hi I was looking at the Zephyr for Greybus <https://github.com/cfriedt/greybus-for-zephyr/> work, and realized that the actual spec for greybus doesn't actually have support for ADC. My usecase is to use the ADCs on an attached microcontroller as if they are native ADCs on a Linux machine. I understand this is more complicated than it looks - because unlike a GPIO, or I2C, there's no such thing as a native ADC for the Linux side of things. Have I understood that correctly? I stumbled into the IIO subsystem for such requirements where there's some analog sensor that would need to be read - but that would not work through a microcontroller like my use case. If one were to look at adding such support, what would they need? Is this something that's been discussed before? Would love to understand this a bit more, and potentially contribute.

3 years, 7 months

[PATCH] greybus: use pm_runtime_resume_and_get() to replace open coding

by Tian Tao

use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and pm_runtime_put_noidle. this change is just to simplify the code, no actual functional changes. Signed-off-by: Tian Tao <tiantao6(a)hisilicon.com> --- drivers/greybus/core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/greybus/core.c b/drivers/greybus/core.c index e546c64..434aa5d 100644 --- a/drivers/greybus/core.c +++ b/drivers/greybus/core.c @@ -174,11 +174,9 @@ static int greybus_probe(struct device *dev) if (!id) return -ENODEV; - retval = pm_runtime_get_sync(&bundle->intf->dev); - if (retval < 0) { - pm_runtime_put_noidle(&bundle->intf->dev); + retval = pm_runtime_resume_and_get(&bundle->intf->dev); + if (retval < 0) return retval; - } retval = gb_control_bundle_activate(bundle->intf->control, bundle->id); if (retval) { -- 2.7.4

3 years, 7 months

[PATCH] staging: greybus: spi: add blank line after variable declaration

by Philippe Dixon

This patch fixes the following checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: Philippe Dixon <philippesdixon(a)gmail.com> --- drivers/staging/greybus/spilib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/greybus/spilib.c b/drivers/staging/greybus/spilib.c index 30655153df6a..ad0700a0bb81 100644 --- a/drivers/staging/greybus/spilib.c +++ b/drivers/staging/greybus/spilib.c @@ -246,6 +246,7 @@ static struct gb_operation *gb_spi_operation_create(struct gb_spilib *spi, xfer = spi->first_xfer; while (msg->state != GB_SPI_STATE_OP_DONE) { int xfer_delay; + if (xfer == spi->last_xfer) xfer_len = spi->last_xfer_size; else -- 2.25.1

3 years, 7 months

[PATCH V2] Staging: greybus: fix open parenthesis error in gbphy.c

by F.A.Sulaiman

This patch fix "Alignment should match open parenthesis" checkpatch error. Signed-off-by: "F.A.Sulaiman" <asha.16(a)itfac.mrt.ac.lk> --- drivers/staging/greybus/gbphy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c index 9fc5c47be9bd..13d319860da5 100644 --- a/drivers/staging/greybus/gbphy.c +++ b/drivers/staging/greybus/gbphy.c @@ -27,7 +27,7 @@ struct gbphy_host { static DEFINE_IDA(gbphy_id); static ssize_t protocol_id_show(struct device *dev, - struct device_attribute *attr, char *buf) + struct device_attribute *attr, char *buf) { struct gbphy_device *gbphy_dev = to_gbphy_dev(dev); @@ -221,7 +221,7 @@ void gb_gbphy_deregister_driver(struct gbphy_driver *driver) EXPORT_SYMBOL_GPL(gb_gbphy_deregister_driver); static struct gbphy_device *gb_gbphy_create_dev(struct gb_bundle *bundle, - struct greybus_descriptor_cport *cport_desc) + struct greybus_descriptor_cport *cport_desc) { struct gbphy_device *gbphy_dev; int retval; -- 2.17.1

3 years, 7 months

[PATCH] Staging: greybus: fix open parenthesis issue in gbphy.c

by F.A.Sulaiman

This fix "Alignment should match open parenthesis" checkpatch error. Signed-off-by: "F.A.Sulaiman" <asha.16(a)itfac.mrt.ac.lk> --- drivers/staging/greybus/gbphy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c index 9fc5c47be9bd..13d319860da5 100644 --- a/drivers/staging/greybus/gbphy.c +++ b/drivers/staging/greybus/gbphy.c @@ -27,7 +27,7 @@ struct gbphy_host { static DEFINE_IDA(gbphy_id); static ssize_t protocol_id_show(struct device *dev, - struct device_attribute *attr, char *buf) + struct device_attribute *attr, char *buf) { struct gbphy_device *gbphy_dev = to_gbphy_dev(dev); @@ -221,7 +221,7 @@ void gb_gbphy_deregister_driver(struct gbphy_driver *driver) EXPORT_SYMBOL_GPL(gb_gbphy_deregister_driver); static struct gbphy_device *gb_gbphy_create_dev(struct gb_bundle *bundle, - struct greybus_descriptor_cport *cport_desc) + struct greybus_descriptor_cport *cport_desc) { struct gbphy_device *gbphy_dev; int retval; -- 2.17.1

3 years, 7 months

[PATCH] Staging: greybus: fix open parenthesis issue in gbphy.c

by F.A.Sulaiman

3 years, 7 months

[PATCH] Staging: greybus: fix open parenthesis issue in gbphy.c

by F.A.Sulaiman

3 years, 7 months

[PATCH] greybus: audio: Fix sparse warning.

by Rajat Asthana

Enforce int type on SNDRV_CTL_ELEM_IFACE_MIXER to fix sparse warning: > warning: restricted snd_ctl_elem_iface_t degrades to integer The iface field in the gb_audio_control struct is of type __u8, but the values stored in it are of type int. So on conversion they are degraded. Adding (__force int) will enforce them not to be degraded. Signed-off-by: Rajat Asthana <thisisrast7(a)gmail.com> --- drivers/staging/greybus/audio_topology.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c index 1fc7727ab7be..1e613d42d823 100644 --- a/drivers/staging/greybus/audio_topology.c +++ b/drivers/staging/greybus/audio_topology.c @@ -676,7 +676,7 @@ static int gbaudio_tplg_create_kcontrol(struct gbaudio_module_info *gb, struct gbaudio_ctl_pvt *ctldata; switch (ctl->iface) { - case SNDRV_CTL_ELEM_IFACE_MIXER: + case (__force int)SNDRV_CTL_ELEM_IFACE_MIXER: switch (ctl->info.type) { case GB_AUDIO_CTL_ELEM_TYPE_ENUMERATED: ret = gbaudio_tplg_create_enum_kctl(gb, kctl, ctl); @@ -903,7 +903,7 @@ static int gbaudio_tplg_create_wcontrol(struct gbaudio_module_info *gb, int ret; switch (ctl->iface) { - case SNDRV_CTL_ELEM_IFACE_MIXER: + case (__force int)SNDRV_CTL_ELEM_IFACE_MIXER: switch (ctl->info.type) { case GB_AUDIO_CTL_ELEM_TYPE_ENUMERATED: ret = gbaudio_tplg_create_enum_ctl(gb, kctl, ctl); -- 2.31.1

3 years, 7 months

[PATCH] staging: greybus: fix some formatting issues

by Wang Qing

fixing WARNING: void function return statements are not generally useful Signed-off-by: Wang Qing <wangqing(a)vivo.com> --- drivers/staging/greybus/audio_codec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index b589cf6..ffd8997 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -1028,7 +1028,6 @@ static int gbcodec_probe(struct snd_soc_component *comp) static void gbcodec_remove(struct snd_soc_component *comp) { /* Empty function for now */ - return; } static int gbcodec_write(struct snd_soc_component *comp, unsigned int reg, -- 2.7.4

3 years, 8 months

[PATCH] Fix typo in commented code. Issue found by checkpatch

by Yusup Badiev

This patch changes the typo "Atleast" -> "At least" as checkpatch.pl warned Signed-off-by: Yusup Badiev <ybadiev(a)gmail.com> --- drivers/staging/greybus/arche-apb-ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c index bbf3ba744fc4..45afa208d004 100644 --- a/drivers/staging/greybus/arche-apb-ctrl.c +++ b/drivers/staging/greybus/arche-apb-ctrl.c @@ -445,7 +445,7 @@ static int __maybe_unused arche_apb_ctrl_suspend(struct device *dev) static int __maybe_unused arche_apb_ctrl_resume(struct device *dev) { /* - * Atleast for ES2 we have to meet the delay requirement between + * At least for ES2 we have to meet the delay requirement between * unipro switch and AP bridge init, depending on whether bridge is in * OFF state or standby state. * -- 2.25.1

3 years, 8 months

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev May 2021