On 5/19/21 1:19 PM, F.A.Sulaiman wrote:

This patch fix "Alignment should match open parenthesis" checkpatch error.

Signed-off-by: "F.A.Sulaiman" asha.16@itfac.mrt.ac.lk

I have mixed feelings about this one. This alignment rule is fine, but I personally don't think it improves things.

Aside from that, there are a few more places in the Greybus code that lead to exactly this warning. So I guess, if we're going to have the code follow this alignment rule, why not just fix all spots at once (i.e., in a patch series)?

Anyway, I'll offer this, but perhaps others can provide their opinion.

Acked-by: Alex Elder elder@linaro.org

---

drivers/staging/greybus/gbphy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c index 9fc5c47be9bd..13d319860da5 100644 --- a/drivers/staging/greybus/gbphy.c +++ b/drivers/staging/greybus/gbphy.c @@ -27,7 +27,7 @@ struct gbphy_host { static DEFINE_IDA(gbphy_id); static ssize_t protocol_id_show(struct device *dev,

• 		 struct device_attribute *attr, char *buf)
  

• 		struct device_attribute *attr, char *buf)
  

  { struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);

@@ -221,7 +221,7 @@ void gb_gbphy_deregister_driver(struct gbphy_driver *driver) EXPORT_SYMBOL_GPL(gb_gbphy_deregister_driver); static struct gbphy_device *gb_gbphy_create_dev(struct gb_bundle *bundle,

• 		struct greybus_descriptor_cport *cport_desc)
  

• 				struct greybus_descriptor_cport *cport_desc)
  

  { struct gbphy_device *gbphy_dev; int retval;