- This series fixes -Wformat-truncation warnings in staging drivers found with W=1 builds:
- greybus: prefix device id to widget/control names safely
- vc04_services/bcm2835-camera: compose V4L2 bus_info safely
Both changes use scnprintf() for the prefix and strscpy() for the remainder. No functional change
intended.
Masaharu Noguchi (2):
staging: greybus: audio_topology: avoid -Wformat-truncation
staging: vc04_services: bcm2835-camera: avoid -Wformat-truncation
drivers/staging/greybus/audio_topology.c | 11 ++++++-----
.../vc04_services/bcm2835-camera/bcm2835-camera.c | 5 +++--
2 files changed, 9 insertions(+), 7 deletions(-)
--
2.39.5
Hi,
This patchset brings support for Silicon Labs' CPC protocol as transport
layer for Greybus. As an example, a SPI driver is added as physical
layer and everything is bundled as a big kernel module. In the future,
as we plan to support other physical layers like SDIO, CPC core will be
its own module, and each physical layer CPC driver will be its own
module as well.
CPC implements some of the features of Unipro that Greybus relies upon,
like reliable transmission. CPC takes care of detecting transmission
errors and retransmit frames if necessary. There's also a flow-control
feature, preventing sending messages to full cports.
In addition to the host device over SPI part, there's also a class
driver for a vendor protocol that enables Bluetooth on supported
devices. This is mostly there to open the discussion on how a new
protocol should be added to Greybus.
Damien Riégel (6):
greybus: move host controller drivers comment in Makefile
greybus: cpc: add core logic
greybus: cpc: add SPI driver
greybus: add API for async unidirectional transfer
greybus: match device with bundle ID
greybus: add class driver for Silabs Bluetooth
MAINTAINERS | 12 +
drivers/greybus/Kconfig | 2 +
drivers/greybus/Makefile | 4 +-
drivers/greybus/core.c | 4 +
drivers/greybus/cpc/Kconfig | 12 +
drivers/greybus/cpc/Makefile | 6 +
drivers/greybus/cpc/cpc.h | 135 +++++++
drivers/greybus/cpc/endpoint.c | 158 ++++++++
drivers/greybus/cpc/header.c | 212 ++++++++++
drivers/greybus/cpc/header.h | 81 ++++
drivers/greybus/cpc/host.c | 113 ++++++
drivers/greybus/cpc/protocol.c | 274 +++++++++++++
drivers/greybus/cpc/spi.c | 585 +++++++++++++++++++++++++++
drivers/greybus/operation.c | 52 +++
drivers/staging/greybus/Kconfig | 9 +
drivers/staging/greybus/Makefile | 6 +
drivers/staging/greybus/silabs-ble.c | 203 ++++++++++
include/linux/greybus.h | 7 +-
include/linux/greybus/greybus_id.h | 2 +
include/linux/greybus/operation.h | 4 +
20 files changed, 1877 insertions(+), 4 deletions(-)
create mode 100644 drivers/greybus/cpc/Kconfig
create mode 100644 drivers/greybus/cpc/Makefile
create mode 100644 drivers/greybus/cpc/cpc.h
create mode 100644 drivers/greybus/cpc/endpoint.c
create mode 100644 drivers/greybus/cpc/header.c
create mode 100644 drivers/greybus/cpc/header.h
create mode 100644 drivers/greybus/cpc/host.c
create mode 100644 drivers/greybus/cpc/protocol.c
create mode 100644 drivers/greybus/cpc/spi.c
create mode 100644 drivers/staging/greybus/silabs-ble.c
--
2.49.0
Hey Akhil,
Thanks for your patch.
All looks good with the exception of a small nit...
On Mon Jul 14, 2025 at 2:56 PM WEST, Akhil Varkey wrote:
> Fix checkpatch check "CHECK:Alignment should match open parenthesis"
>
> Signed-off-by: Akhil Varkey <akhilvarkey(a)disroot.org>
> ---
>
> Hello, This is my first patch, I appreciate any feedbacks. Thanks!!
Welcome, and continue...
> ---
> drivers/staging/greybus/power_supply.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/greybus/power_supply.c b/drivers/staging/greybus/power_supply.c
> index 2ef46822f676..a484c0ca058d 100644
> --- a/drivers/staging/greybus/power_supply.c
> +++ b/drivers/staging/greybus/power_supply.c
> @@ -324,7 +324,7 @@ static struct gb_power_supply_prop *get_psy_prop(struct gb_power_supply *gbpsy,
> }
>
> static int is_psy_prop_writeable(struct gb_power_supply *gbpsy,
> - enum power_supply_property psp)
> + enum power_supply_property psp)
> {
> struct gb_power_supply_prop *prop;
>
> @@ -493,7 +493,7 @@ static int gb_power_supply_description_get(struct gb_power_supply *gbpsy)
> if (!gbpsy->model_name)
> return -ENOMEM;
> gbpsy->serial_number = kstrndup(resp.serial_number, PROP_MAX,
> - GFP_KERNEL);
> + GFP_KERNEL);
> if (!gbpsy->serial_number)
> return -ENOMEM;
>
> @@ -546,7 +546,7 @@ static int gb_power_supply_prop_descriptors_get(struct gb_power_supply *gbpsy)
> }
>
> gbpsy->props = kcalloc(gbpsy->properties_count, sizeof(*gbpsy->props),
> - GFP_KERNEL);
> + GFP_KERNEL);
> if (!gbpsy->props) {
> ret = -ENOMEM;
> goto out_put_operation;
> @@ -634,8 +634,8 @@ static int __gb_power_supply_property_get(struct gb_power_supply *gbpsy,
> }
>
> static int __gb_power_supply_property_strval_get(struct gb_power_supply *gbpsy,
> - enum power_supply_property psp,
> - union power_supply_propval *val)
> + enum power_supply_property psp,
> + union power_supply_propval *val)
Here you fix the alignment, but the last line goes over column 81, even
though 80 is not really one hard requirement anymore, all code
(strings is ok to go over to be easier to grep for messages) is on that
register.
So, to be coherent, if you could please send a V2 without this specific change
would be great, Or even better, if you could get rid of all the _ and __
prefixes in functions names that would be great, and will give more
space for function paramethers.
Your call.
Also, gives you also the chance to practice to send a new
version ;).
Cheers,
Rui
> {
> switch (psp) {
> case POWER_SUPPLY_PROP_MODEL_NAME:
> @@ -943,8 +943,8 @@ static int gb_power_supplies_setup(struct gb_power_supplies *supplies)
> goto out;
>
> supplies->supply = kcalloc(supplies->supplies_count,
> - sizeof(struct gb_power_supply),
> - GFP_KERNEL);
> + sizeof(struct gb_power_supply),
> + GFP_KERNEL);
>
> if (!supplies->supply) {
> ret = -ENOMEM;
> --
> 2.47.2