This patch set include multiple fixes for the issues reported by
checkpatch.pl
Cc: greybus-dev(a)lists.linaro.org
Cc: Viresh Kumar <vireshk(a)kernel.org>
Cc: Vaibhav Agarwal <vaibhav.sr(a)gmail.com>
Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Changes from v2:
- [2/8] Restore the original alignment.
Changes from v1:
- Rebase the changes on top staging-next.
- Add greybus-dev mailing list.
Kamal Heib (8):
staging: greybus: authentication.c: Fix alignment should match open
parenthesis
staging: greybus: audio_codec.c: Fix alignment should match open
parenthesis
staging: greybus: audio_codec.c: Cleanup blank lines
staging: greybus: audio_codec.c: Space required around ':'
staging: greybus: audio_codec.c: Logical continuations should be on
the previous line
staging: greybus: audio_codec.c: Prefer kernel type 'u32' over
'uint32_t'
staging: greybus: audio_codec.h: Prefer kernel type 'u32' over
'uint32_t'
staging: greybus: audio_codec.h Fix alignment should match open
parenthesis
drivers/staging/greybus/audio_codec.c | 23 ++++++++++-------------
drivers/staging/greybus/audio_codec.h | 12 ++++++------
drivers/staging/greybus/authentication.c | 2 +-
3 files changed, 17 insertions(+), 20 deletions(-)
--
2.14.3
This patch set include multiple fixes for the issues reported by
checkpatch.pl
Cc: greybus-dev(a)lists.linaro.org
Cc: Viresh Kumar <vireshk(a)kernel.org>
Cc: Vaibhav Agarwal <vaibhav.sr(a)gmail.com>
Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Changes from v1:
- Rebase the changes on top staging-next.
- Add greybus-dev mailing list.
Kamal Heib (8):
staging: greybus: authentication.c: Fix alignment should match open
parenthesis
staging: greybus: audio_codec.c: Fix alignment should match open
parenthesis
staging: greybus: audio_codec.c: Cleanup blank lines
staging: greybus: audio_codec.c: Space required around ':'
staging: greybus: audio_codec.c: Logical continuations should be on
the previous line
staging: greybus: audio_codec.c: Prefer kernel type 'u32' over
'uint32_t'
staging: greybus: audio_codec.h: Prefer kernel type 'u32' over
'uint32_t'
staging: greybus: audio_codec.h Fix alignment should match open
parenthesis
drivers/staging/greybus/audio_codec.c | 31 ++++++++++++++-----------------
drivers/staging/greybus/audio_codec.h | 12 ++++++------
drivers/staging/greybus/authentication.c | 2 +-
3 files changed, 21 insertions(+), 24 deletions(-)
--
2.14.3
4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Bryan O'Donoghue <pure.logic(a)nexus-software.ie>
[ Upstream commit 44b02da39210e6dd67e39ff1f48d30c56d384240 ]
Commit 12927835d211 ("greybus: loopback: Add asynchronous bi-directional
support") does what it says on the tin - namely, adds support for
asynchronous bi-directional loopback operations.
What it neglects to do though is increment the per-connection
gb->iteration_count on an asynchronous operation error. This patch fixes
that omission.
Fixes: 12927835d211 ("greybus: loopback: Add asynchronous bi-directional support")
Signed-off-by: Bryan O'Donoghue <pure.logic(a)nexus-software.ie>
Reported-by: Mitch Tasman <tasman(a)leaflabs.com>
Reviewed-by: Johan Hovold <johan(a)kernel.org>
Cc: Alex Elder <elder(a)kernel.org>
Cc: Mitch Tasman <tasman(a)leaflabs.com>
Cc: greybus-dev(a)lists.linaro.org
Cc: devel(a)driverdev.osuosl.org
Cc: linux-kernel(a)vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin(a)verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
---
drivers/staging/greybus/loopback.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -1042,8 +1042,10 @@ static int gb_loopback_fn(void *data)
else if (type == GB_LOOPBACK_TYPE_SINK)
error = gb_loopback_async_sink(gb, size);
- if (error)
+ if (error) {
gb->error++;
+ gb->iteration_count++;
+ }
} else {
/* We are effectively single threaded here */
if (type == GB_LOOPBACK_TYPE_PING)
4.9-stable review patch. If anyone has any objections, please let me know.
------------------
From: Bryan O'Donoghue <pure.logic(a)nexus-software.ie>
[ Upstream commit 44b02da39210e6dd67e39ff1f48d30c56d384240 ]
Commit 12927835d211 ("greybus: loopback: Add asynchronous bi-directional
support") does what it says on the tin - namely, adds support for
asynchronous bi-directional loopback operations.
What it neglects to do though is increment the per-connection
gb->iteration_count on an asynchronous operation error. This patch fixes
that omission.
Fixes: 12927835d211 ("greybus: loopback: Add asynchronous bi-directional support")
Signed-off-by: Bryan O'Donoghue <pure.logic(a)nexus-software.ie>
Reported-by: Mitch Tasman <tasman(a)leaflabs.com>
Reviewed-by: Johan Hovold <johan(a)kernel.org>
Cc: Alex Elder <elder(a)kernel.org>
Cc: Mitch Tasman <tasman(a)leaflabs.com>
Cc: greybus-dev(a)lists.linaro.org
Cc: devel(a)driverdev.osuosl.org
Cc: linux-kernel(a)vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin(a)verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
---
drivers/staging/greybus/loopback.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -1034,8 +1034,10 @@ static int gb_loopback_fn(void *data)
error = gb_loopback_async_sink(gb, size);
}
- if (error)
+ if (error) {
gb->error++;
+ gb->iteration_count++;
+ }
} else {
/* We are effectively single threaded here */
if (type == GB_LOOPBACK_TYPE_PING)