greybus-dev

greybus-dev@lists.linaro.org

6 participants
595 discussions

binding gb gpio device to gb-phy driver?

by Christopher Friedt

Hi List! I'm currently using gbridge / tcpip with the IID1-simple-gpio-module.mnfs example to hook up a fake module that just responds to socket I/O. A couple of small changes were required, but everything seems to be parsed, bundles, cports are all created. However, for some reason, greybus does not seem to automatically bind the device to the gb-gpio driver, nor does it probe the device. I only see pings after the svc has inserted my fake module and handshake is complete. Is anyone aware if a separate step that is required to bind the device to the driver? I've tried sudo sh -c 'echo -n 1-2.2.1 > /sys/bus/gbphy/drivers/gpio/bind' but that gives me -ENODEV Any pointers would be great! Thanks, C

6 years, 2 months

Greybus For IoT : Click Board Support on Beaglebone Boards

by Vaishnav MA

Hi, I have been working on the Google Summer of Code Project : Click Board Support through Greybus <https://summerofcode.withgoogle.com/projects/#5996499987595264> , which aims to bring in support for MikroElektronika Click Boards <https://www.mikroe.com/click> through Greybus Simulator <https://github.com/projectara/gbsim> , I was able to set up and bring in support for some of the Click boards through Greybus Simulator and passing the properties related to the Click Board device driver manipulating the product string and vendor string properties in the manifest, however I am stuck now as some of the click boards require additional platform data(like Reset Pin, Interrupts..etc) passed to the spi_new_device/i2c_new_device calls, does Greybus allow passing of these parameters to the driver, if so can someone guide me with the documentation for the same or point me a suitable example so that I can implement the solution in the project. If greybus doesn't allow for passing these parameters what would be the ideal way to bring in support for these click boards(which mostly uses SPI/I2C interfaces) through the greybus subsystem?. Thanks and Regards Vaishnav M A GSoC '19 Student Under Beagleboard.org

6 years, 2 months

[PATCH] staging: greybus: add logging statement when kfifo_alloc fails

by Keyur Patel

Added missing logging statement when kfifo_alloc fails, to improve debugging. Signed-off-by: Keyur Patel <iamkeyur96(a)gmail.com> --- drivers/staging/greybus/uart.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index b3bffe91ae99..86a395ae177d 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -856,8 +856,10 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev, retval = kfifo_alloc(&gb_tty->write_fifo, GB_UART_WRITE_FIFO_SIZE, GFP_KERNEL); - if (retval) + if (retval) { + pr_err("kfifo_alloc failed\n"); goto exit_buf_free; + } gb_tty->credits = GB_UART_FIRMWARE_CREDITS; init_completion(&gb_tty->credits_complete); -- 2.22.0

6 years, 3 months

[PATCH] staging: greybus: Replace function gb_i2c_device_setup()

by Nishka Dasgupta

Remove function gb_i2c_device_setup as all it does is call gb_i2c_functionality_operation. Rename gb_i2c_functionality_operation to gb_i2c_device_setup to maintain compatibility with call sites. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishkadg.linux(a)gmail.com> --- drivers/staging/greybus/i2c.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/staging/greybus/i2c.c b/drivers/staging/greybus/i2c.c index 7bb85a75d3b1..b2522043a1a4 100644 --- a/drivers/staging/greybus/i2c.c +++ b/drivers/staging/greybus/i2c.c @@ -31,7 +31,14 @@ static u32 gb_i2c_functionality_map(u32 gb_i2c_functionality) return gb_i2c_functionality; /* All bits the same for now */ } -static int gb_i2c_functionality_operation(struct gb_i2c_device *gb_i2c_dev) +/* + * Do initial setup of the i2c device. This includes verifying we + * can support it (based on the protocol version it advertises). + * If that's OK, we get and cached its functionality bits. + * + * Note: gb_i2c_dev->connection is assumed to have been valid. + */ +static int gb_i2c_device_setup(struct gb_i2c_device *gb_i2c_dev) { struct gb_i2c_functionality_response response; u32 functionality; @@ -235,19 +242,6 @@ static const struct i2c_algorithm gb_i2c_algorithm = { .functionality = gb_i2c_functionality, }; -/* - * Do initial setup of the i2c device. This includes verifying we - * can support it (based on the protocol version it advertises). - * If that's OK, we get and cached its functionality bits. - * - * Note: gb_i2c_dev->connection is assumed to have been valid. - */ -static int gb_i2c_device_setup(struct gb_i2c_device *gb_i2c_dev) -{ - /* Assume the functionality never changes, just get it once */ - return gb_i2c_functionality_operation(gb_i2c_dev); -} - static int gb_i2c_probe(struct gbphy_device *gbphy_dev, const struct gbphy_device_id *id) { -- 2.19.1

6 years, 3 months

[PATCH] staging: greybus: remove redundant assignment to variable is_empty

by Colin King

From: Colin Ian King <colin.king(a)canonical.com> The variable is_empty is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/staging/greybus/audio_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c index c2a4af4c1d06..9b19ea9d3fa1 100644 --- a/drivers/staging/greybus/audio_manager.c +++ b/drivers/staging/greybus/audio_manager.c @@ -86,7 +86,7 @@ EXPORT_SYMBOL_GPL(gb_audio_manager_remove); void gb_audio_manager_remove_all(void) { struct gb_audio_manager_module *module, *next; - int is_empty = 1; + int is_empty; down_write(&modules_rwsem); -- 2.20.1

6 years, 3 months

Anyone else having delays with this list?

by Mark Greer

Hi everyone. Is anyone else experiencing delays receiving email from this list? I just received a bunch today (April 30) with some emails dating back as far as Jan 15. Thanks, Mark --

6 years, 4 months

[PATCH] staging: greybus: tools: Remove function log_csv_error()

by Nishka Dasgupta

Remove unused function log_csv_error. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishkadg.linux(a)gmail.com> --- drivers/staging/greybus/tools/loopback_test.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c index 2fa88092514d..cebc1d90a180 100644 --- a/drivers/staging/greybus/tools/loopback_test.c +++ b/drivers/staging/greybus/tools/loopback_test.c @@ -414,12 +414,6 @@ static int get_results(struct loopback_test *t) return 0; } -void log_csv_error(int len, int err) -{ - fprintf(stderr, "unable to write %d bytes to csv %s\n", len, - strerror(err)); -} - int format_output(struct loopback_test *t, struct loopback_results *r, const char *dev_name, -- 2.19.1

6 years, 4 months

[PATCH] greybus: audio_manager: fix a missing check of ida_simple_get

by Kangjie Lu

ida_simple_get could fail. The fix inserts a check for its return value. Signed-off-by: Kangjie Lu <kjlu(a)umn.edu> --- drivers/staging/greybus/audio_manager.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c index d44b070d8862..c2a4af4c1d06 100644 --- a/drivers/staging/greybus/audio_manager.c +++ b/drivers/staging/greybus/audio_manager.c @@ -45,6 +45,9 @@ int gb_audio_manager_add(struct gb_audio_manager_module_descriptor *desc) int err; id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL); + if (id < 0) + return id; + err = gb_audio_manager_module_create(&module, manager_kset, id, desc); if (err) { -- 2.17.1

6 years, 6 months

Re: [greybus-dev] [PATCH] staging: greybus: use proper return type for wait_for_completion_timeout

by Dan Carpenter

On Sat, Apr 27, 2019 at 05:27:25AM +0200, Nicholas Mc Guire wrote: > wait_for_completion_timeout() returns unsigned long (0 on timeout or > remaining jiffies) not int. > Yeah, but it's fine though because 10000 / 256 fits into int without a problem. I'm not sure this sort of patch is worth it when it's just a style debate instead of a bugfix. I'm a little bit torn about this. In Smatch, I run into this issue one in a while where Smatch doesn't know if the timeout is less than int. Right now I hacked the DB to say that these functions always return < INT_MAX. Anyway, for sure the commit message should say that it's just a cleanup and not a bugfix. regards, dan carpenter

6 years, 6 months

[PATCH] staging: greybus: use help instead of ---help--- in Kconfig

by MosesChristopher

From: Moses Christopher <moseschristopherb(a)gmail.com> - Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts" Signed-off-by: Moses Christopher <moseschristopherb(a)gmail.com> --- drivers/staging/greybus/Kconfig | 44 ++++++++++++++++++++--------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/greybus/Kconfig b/drivers/staging/greybus/Kconfig index b571e4e8060b..2f5061b565a6 100644 --- a/drivers/staging/greybus/Kconfig +++ b/drivers/staging/greybus/Kconfig @@ -1,7 +1,7 @@ menuconfig GREYBUS tristate "Greybus support" depends on SYSFS - ---help--- + help This option enables the Greybus driver core. Greybus is an hardware protocol that was designed to provide Unipro with a sane application layer. It was originally designed for the @@ -19,7 +19,7 @@ if GREYBUS config GREYBUS_ES2 tristate "Greybus ES3 USB host controller" depends on USB - ---help--- + help Select this option if you have a Toshiba ES3 USB device that acts as a Greybus "host controller". This device is a bridge from a USB device to a Unipro network. @@ -30,7 +30,7 @@ config GREYBUS_ES2 config GREYBUS_AUDIO tristate "Greybus Audio Class driver" depends on SOUND - ---help--- + help Select this option if you have a device that follows the Greybus Audio Class specification. @@ -39,7 +39,7 @@ config GREYBUS_AUDIO config GREYBUS_BOOTROM tristate "Greybus Bootrom Class driver" - ---help--- + help Select this option if you have a device that follows the Greybus Bootrom Class specification. @@ -49,7 +49,7 @@ config GREYBUS_BOOTROM config GREYBUS_CAMERA tristate "Greybus Camera Class driver" depends on MEDIA_SUPPORT && LEDS_CLASS_FLASH && BROKEN - ---help--- + help Select this option if you have a device that follows the Greybus Camera Class specification. @@ -59,7 +59,7 @@ config GREYBUS_CAMERA config GREYBUS_FIRMWARE tristate "Greybus Firmware Download Class driver" depends on SPI - ---help--- + help Select this option if you have a device that follows the Greybus Firmware Download Class specification. @@ -69,7 +69,7 @@ config GREYBUS_FIRMWARE config GREYBUS_HID tristate "Greybus HID Class driver" depends on HID && INPUT - ---help--- + help Select this option if you have a device that follows the Greybus HID Class specification. @@ -79,7 +79,7 @@ config GREYBUS_HID config GREYBUS_LIGHT tristate "Greybus LED Class driver" depends on LEDS_CLASS - ---help--- + help Select this option if you have a device that follows the Greybus LED Class specification. @@ -88,7 +88,7 @@ config GREYBUS_LIGHT config GREYBUS_LOG tristate "Greybus Debug Log Class driver" - ---help--- + help Select this option if you have a device that follows the Greybus Debug Log Class specification. @@ -97,7 +97,7 @@ config GREYBUS_LOG config GREYBUS_LOOPBACK tristate "Greybus Loopback Class driver" - ---help--- + help Select this option if you have a device that follows the Greybus Debug Log Class specification. @@ -107,7 +107,7 @@ config GREYBUS_LOOPBACK config GREYBUS_POWER tristate "Greybus Powersupply Class driver" depends on POWER_SUPPLY - ---help--- + help Select this option if you have a device that follows the Greybus Powersupply Class specification. @@ -116,7 +116,7 @@ config GREYBUS_POWER config GREYBUS_RAW tristate "Greybus Raw Class driver" - ---help--- + help Select this option if you have a device that follows the Greybus Raw Class specification. @@ -125,7 +125,7 @@ config GREYBUS_RAW config GREYBUS_VIBRATOR tristate "Greybus Vibrator Motor Class driver" - ---help--- + help Select this option if you have a device that follows the Greybus Vibrator Motor Class specification. @@ -134,7 +134,7 @@ config GREYBUS_VIBRATOR menuconfig GREYBUS_BRIDGED_PHY tristate "Greybus Bridged PHY Class drivers" - ---help--- + help Select this option to pick from a variety of Greybus Bridged PHY class drivers. These drivers emulate a number of different "traditional" busses by tunneling them over Greybus. @@ -149,7 +149,7 @@ config GREYBUS_GPIO tristate "Greybus GPIO Bridged PHY driver" depends on GPIOLIB select GPIOLIB_IRQCHIP - ---help--- + help Select this option if you have a device that follows the Greybus GPIO Bridged PHY Class specification. @@ -159,7 +159,7 @@ config GREYBUS_GPIO config GREYBUS_I2C tristate "Greybus I2C Bridged PHY driver" depends on I2C - ---help--- + help Select this option if you have a device that follows the Greybus I2C Bridged PHY Class specification. @@ -169,7 +169,7 @@ config GREYBUS_I2C config GREYBUS_PWM tristate "Greybus PWM Bridged PHY driver" depends on PWM - ---help--- + help Select this option if you have a device that follows the Greybus PWM Bridged PHY Class specification. @@ -179,7 +179,7 @@ config GREYBUS_PWM config GREYBUS_SDIO tristate "Greybus SDIO Bridged PHY driver" depends on MMC - ---help--- + help Select this option if you have a device that follows the Greybus SDIO Bridged PHY Class specification. @@ -189,7 +189,7 @@ config GREYBUS_SDIO config GREYBUS_SPI tristate "Greybus SPI Bridged PHY driver" depends on SPI - ---help--- + help Select this option if you have a device that follows the Greybus SPI Bridged PHY Class specification. @@ -199,7 +199,7 @@ config GREYBUS_SPI config GREYBUS_UART tristate "Greybus UART Bridged PHY driver" depends on TTY - ---help--- + help Select this option if you have a device that follows the Greybus UART Bridged PHY Class specification. @@ -209,7 +209,7 @@ config GREYBUS_UART config GREYBUS_USB tristate "Greybus USB Host Bridged PHY driver" depends on USB - ---help--- + help Select this option if you have a device that follows the Greybus USB Host Bridged PHY Class specification. @@ -221,7 +221,7 @@ endif # GREYBUS_BRIDGED_PHY config GREYBUS_ARCHE tristate "Greybus Arche Platform driver" depends on USB_HSIC_USB3613 || COMPILE_TEST - ---help--- + help Select this option if you have an Arche device. To compile this code as a module, chose M here: the module -- 2.11.0

6 years, 6 months

← Newer
1
...
41
42
43
44
45
46
47
...
60
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev