greybus-dev

greybus-dev@lists.linaro.org

28 participants
853 discussions

[PATCH] Staging: greybus: fix open parenthesis issue in gbphy.c

by F.A.Sulaiman

This fix "Alignment should match open parenthesis" checkpatch error. Signed-off-by: "F.A.Sulaiman" <asha.16(a)itfac.mrt.ac.lk> --- drivers/staging/greybus/gbphy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c index 9fc5c47be9bd..13d319860da5 100644 --- a/drivers/staging/greybus/gbphy.c +++ b/drivers/staging/greybus/gbphy.c @@ -27,7 +27,7 @@ struct gbphy_host { static DEFINE_IDA(gbphy_id); static ssize_t protocol_id_show(struct device *dev, - struct device_attribute *attr, char *buf) + struct device_attribute *attr, char *buf) { struct gbphy_device *gbphy_dev = to_gbphy_dev(dev); @@ -221,7 +221,7 @@ void gb_gbphy_deregister_driver(struct gbphy_driver *driver) EXPORT_SYMBOL_GPL(gb_gbphy_deregister_driver); static struct gbphy_device *gb_gbphy_create_dev(struct gb_bundle *bundle, - struct greybus_descriptor_cport *cport_desc) + struct greybus_descriptor_cport *cport_desc) { struct gbphy_device *gbphy_dev; int retval; -- 2.17.1

5 years, 3 months

[PATCH] Staging: greybus: fix open parenthesis issue in gbphy.c

by F.A.Sulaiman

5 years, 3 months

[PATCH] Staging: greybus: fix open parenthesis issue in gbphy.c

by F.A.Sulaiman

5 years, 3 months

[PATCH] greybus: audio: Fix sparse warning.

by Rajat Asthana

Enforce int type on SNDRV_CTL_ELEM_IFACE_MIXER to fix sparse warning: > warning: restricted snd_ctl_elem_iface_t degrades to integer The iface field in the gb_audio_control struct is of type __u8, but the values stored in it are of type int. So on conversion they are degraded. Adding (__force int) will enforce them not to be degraded. Signed-off-by: Rajat Asthana <thisisrast7(a)gmail.com> --- drivers/staging/greybus/audio_topology.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c index 1fc7727ab7be..1e613d42d823 100644 --- a/drivers/staging/greybus/audio_topology.c +++ b/drivers/staging/greybus/audio_topology.c @@ -676,7 +676,7 @@ static int gbaudio_tplg_create_kcontrol(struct gbaudio_module_info *gb, struct gbaudio_ctl_pvt *ctldata; switch (ctl->iface) { - case SNDRV_CTL_ELEM_IFACE_MIXER: + case (__force int)SNDRV_CTL_ELEM_IFACE_MIXER: switch (ctl->info.type) { case GB_AUDIO_CTL_ELEM_TYPE_ENUMERATED: ret = gbaudio_tplg_create_enum_kctl(gb, kctl, ctl); @@ -903,7 +903,7 @@ static int gbaudio_tplg_create_wcontrol(struct gbaudio_module_info *gb, int ret; switch (ctl->iface) { - case SNDRV_CTL_ELEM_IFACE_MIXER: + case (__force int)SNDRV_CTL_ELEM_IFACE_MIXER: switch (ctl->info.type) { case GB_AUDIO_CTL_ELEM_TYPE_ENUMERATED: ret = gbaudio_tplg_create_enum_ctl(gb, kctl, ctl); -- 2.31.1

5 years, 3 months

[PATCH] staging: greybus: fix some formatting issues

by Wang Qing

fixing WARNING: void function return statements are not generally useful Signed-off-by: Wang Qing <wangqing(a)vivo.com> --- drivers/staging/greybus/audio_codec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index b589cf6..ffd8997 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -1028,7 +1028,6 @@ static int gbcodec_probe(struct snd_soc_component *comp) static void gbcodec_remove(struct snd_soc_component *comp) { /* Empty function for now */ - return; } static int gbcodec_write(struct snd_soc_component *comp, unsigned int reg, -- 2.7.4

5 years, 3 months

[PATCH] Fix typo in commented code. Issue found by checkpatch

by Yusup Badiev

This patch changes the typo "Atleast" -> "At least" as checkpatch.pl warned Signed-off-by: Yusup Badiev <ybadiev(a)gmail.com> --- drivers/staging/greybus/arche-apb-ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c index bbf3ba744fc4..45afa208d004 100644 --- a/drivers/staging/greybus/arche-apb-ctrl.c +++ b/drivers/staging/greybus/arche-apb-ctrl.c @@ -445,7 +445,7 @@ static int __maybe_unused arche_apb_ctrl_suspend(struct device *dev) static int __maybe_unused arche_apb_ctrl_resume(struct device *dev) { /* - * Atleast for ES2 we have to meet the delay requirement between + * At least for ES2 we have to meet the delay requirement between * unipro switch and AP bridge init, depending on whether bridge is in * OFF state or standby state. * -- 2.25.1

5 years, 3 months

[PATCH] staging: greybus: add declare_ to declaring macros

by Shreyansh Chouhan

Prefixed the names of all the macros that were used for declaring things with 'declare_'. This should help with clarifying about what these macros do. Signed-off-by: Shreyansh Chouhan <chouhan.shreyansh630(a)gmail.com> --- drivers/staging/greybus/loopback.c | 56 +++++++++++++++--------------- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index 2471448ba42a..ddbeb33fa3c1 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -119,7 +119,7 @@ module_param(kfifo_depth, uint, 0444); #define GB_LOOPBACK_US_WAIT_MAX 1000000 /* interface sysfs attributes */ -#define gb_loopback_ro_attr(field) \ +#define declare_gb_loopback_ro_attr(field) \ static ssize_t field##_show(struct device *dev, \ struct device_attribute *attr, \ char *buf) \ @@ -129,7 +129,7 @@ static ssize_t field##_show(struct device *dev, \ } \ static DEVICE_ATTR_RO(field) -#define gb_loopback_ro_stats_attr(name, field, type) \ +#define declare_gb_loopback_ro_stats_attr(name, field, type) \ static ssize_t name##_##field##_show(struct device *dev, \ struct device_attribute *attr, \ char *buf) \ @@ -142,7 +142,7 @@ static ssize_t name##_##field##_show(struct device *dev, \ } \ static DEVICE_ATTR_RO(name##_##field) -#define gb_loopback_ro_avg_attr(name) \ +#define declare_gb_loopback_ro_avg_attr(name) \ static ssize_t name##_avg_show(struct device *dev, \ struct device_attribute *attr, \ char *buf) \ @@ -162,12 +162,12 @@ static ssize_t name##_avg_show(struct device *dev, \ } \ static DEVICE_ATTR_RO(name##_avg) -#define gb_loopback_stats_attrs(field) \ - gb_loopback_ro_stats_attr(field, min, u); \ - gb_loopback_ro_stats_attr(field, max, u); \ - gb_loopback_ro_avg_attr(field) +#define declare_gb_loopback_stats_attrs(field) \ + declare_gb_loopback_ro_stats_attr(field, min, u); \ + declare_gb_loopback_ro_stats_attr(field, max, u); \ + declare_gb_loopback_ro_avg_attr(field) -#define gb_loopback_attr(field, type) \ +#define declare_gb_loopback_attr(field, type) \ static ssize_t field##_show(struct device *dev, \ struct device_attribute *attr, \ char *buf) \ @@ -193,7 +193,7 @@ static ssize_t field##_store(struct device *dev, \ } \ static DEVICE_ATTR_RW(field) -#define gb_dev_loopback_ro_attr(field, conn) \ +#define declare_gb_dev_loopback_ro_attr(field, conn) \ static ssize_t field##_show(struct device *dev, \ struct device_attribute *attr, \ char *buf) \ @@ -203,7 +203,7 @@ static ssize_t field##_show(struct device *dev, \ } \ static DEVICE_ATTR_RO(field) -#define gb_dev_loopback_rw_attr(field, type) \ +#define declare_gb_dev_loopback_rw_attr(field, type) \ static ssize_t field##_show(struct device *dev, \ struct device_attribute *attr, \ char *buf) \ @@ -268,26 +268,26 @@ static void gb_loopback_check_attr(struct gb_loopback *gb) } /* Time to send and receive one message */ -gb_loopback_stats_attrs(latency); +declare_gb_loopback_stats_attrs(latency); /* Number of requests sent per second on this cport */ -gb_loopback_stats_attrs(requests_per_second); +declare_gb_loopback_stats_attrs(requests_per_second); /* Quantity of data sent and received on this cport */ -gb_loopback_stats_attrs(throughput); +declare_gb_loopback_stats_attrs(throughput); /* Latency across the UniPro link from APBridge's perspective */ -gb_loopback_stats_attrs(apbridge_unipro_latency); +declare_gb_loopback_stats_attrs(apbridge_unipro_latency); /* Firmware induced overhead in the GPBridge */ -gb_loopback_stats_attrs(gbphy_firmware_latency); +declare_gb_loopback_stats_attrs(gbphy_firmware_latency); /* Number of errors encountered during loop */ -gb_loopback_ro_attr(error); +declare_gb_loopback_ro_attr(error); /* Number of requests successfully completed async */ -gb_loopback_ro_attr(requests_completed); +declare_gb_loopback_ro_attr(requests_completed); /* Number of requests timed out async */ -gb_loopback_ro_attr(requests_timedout); +declare_gb_loopback_ro_attr(requests_timedout); /* Timeout minimum in useconds */ -gb_loopback_ro_attr(timeout_min); +declare_gb_loopback_ro_attr(timeout_min); /* Timeout minimum in useconds */ -gb_loopback_ro_attr(timeout_max); +declare_gb_loopback_ro_attr(timeout_max); /* * Type of loopback message to send based on protocol type definitions @@ -297,21 +297,21 @@ gb_loopback_ro_attr(timeout_max); * payload returned in response) * 4 => Send a sink message (message with payload, no payload in response) */ -gb_dev_loopback_rw_attr(type, d); +declare_gb_dev_loopback_rw_attr(type, d); /* Size of transfer message payload: 0-4096 bytes */ -gb_dev_loopback_rw_attr(size, u); +declare_gb_dev_loopback_rw_attr(size, u); /* Time to wait between two messages: 0-1000 ms */ -gb_dev_loopback_rw_attr(us_wait, d); +declare_gb_dev_loopback_rw_attr(us_wait, d); /* Maximum iterations for a given operation: 1-(2^32-1), 0 implies infinite */ -gb_dev_loopback_rw_attr(iteration_max, u); +declare_gb_dev_loopback_rw_attr(iteration_max, u); /* The current index of the for (i = 0; i < iteration_max; i++) loop */ -gb_dev_loopback_ro_attr(iteration_count, false); +declare_gb_dev_loopback_ro_attr(iteration_count, false); /* A flag to indicate synchronous or asynchronous operations */ -gb_dev_loopback_rw_attr(async, u); +declare_gb_dev_loopback_rw_attr(async, u); /* Timeout of an individual asynchronous request */ -gb_dev_loopback_rw_attr(timeout, u); +declare_gb_dev_loopback_rw_attr(timeout, u); /* Maximum number of in-flight operations before back-off */ -gb_dev_loopback_rw_attr(outstanding_operations_max, u); +declare_gb_dev_loopback_rw_attr(outstanding_operations_max, u); static struct attribute *loopback_attrs[] = { &dev_attr_latency_min.attr, -- 2.31.1

5 years, 3 months

Re: [greybus-dev] [PATCH] staging: greybus: fix gb_loopback_stats_attrs definition

by Greg KH

On Fri, May 14, 2021 at 08:42:16PM +0530, Shreyansh Chouhan wrote: > On Fri, May 14, 2021 at 04:30:23PM +0200, Greg KH wrote: > > On Fri, May 14, 2021 at 07:53:57PM +0530, Shreyansh Chouhan wrote: > > > On Fri, May 14, 2021 at 04:05:32PM +0200, Greg KH wrote: > > > > On Fri, May 14, 2021 at 07:18:38PM +0530, Shreyansh Chouhan wrote: > > > > > On Fri, May 14, 2021 at 03:36:25PM +0200, Greg KH wrote: > > > > > > On Fri, May 14, 2021 at 07:00:39PM +0530, Shreyansh Chouhan wrote: > > > > > > > The gb_loopback_stats_attrs macro, (defined in loopback.c,) is a > > > > > > > multiline macro whose statements were not enclosed in a do while > > > > > > > loop. > > > > > > > > > > > > > > This patch adds a do while loop around the statements of the said > > > > > > > macro. > > > > > > > > > > > > > > Signed-off-by: Shreyansh Chouhan <chouhan.shreyansh630(a)gmail.com> > > > > > > > --- > > > > > > > drivers/staging/greybus/loopback.c | 10 ++++++---- > > > > > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > > > > > > > > > diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c > > > > > > > index 2471448ba42a..c88ef3e894fa 100644 > > > > > > > --- a/drivers/staging/greybus/loopback.c > > > > > > > +++ b/drivers/staging/greybus/loopback.c > > > > > > > @@ -162,10 +162,12 @@ static ssize_t name##_avg_show(struct device *dev, \ > > > > > > > } \ > > > > > > > static DEVICE_ATTR_RO(name##_avg) > > > > > > > > > > > > > > -#define gb_loopback_stats_attrs(field) \ > > > > > > > - gb_loopback_ro_stats_attr(field, min, u); \ > > > > > > > - gb_loopback_ro_stats_attr(field, max, u); \ > > > > > > > - gb_loopback_ro_avg_attr(field) > > > > > > > +#define gb_loopback_stats_attrs(field) \ > > > > > > > + do { \ > > > > > > > + gb_loopback_ro_stats_attr(field, min, u); \ > > > > > > > + gb_loopback_ro_stats_attr(field, max, u); \ > > > > > > > + gb_loopback_ro_avg_attr(field); \ > > > > > > > + } while (0) > > > > > > > > > > > > > > #define gb_loopback_attr(field, type) \ > > > > > > > static ssize_t field##_show(struct device *dev, \ > > > > > > > -- > > > > > > > 2.31.1 > > > > > > > > > > > > > > > > > > > > > > > > > > Did you test build this change? > > > > > > > > > > I built the module using make -C . M=drivers/staging/greybus to test > > > > > build it. I didn't get any errors. > > > > > > > > Really? Can you provide the full build output for this file with your > > > > change? I don't think you really built this file for the obvious > > > > reasons... > > > > > > I ran make -C . M=drivers/staging/greybus > > > > > > I got a three line output saying: > > > make: Entering directory '/work/linux' > > > MODPOST drivers/staging/greybus//Module.symvers > > > make: Leaving directory '/work/linux' > > > > > > I just tried rebuilding the kernel with CONFIG_GREYBUS=m, and now I can > > > see what you are talking about. Why weren't these errors reported when I > > > ran the previous make command? Does that too check for the config > > > variables even when I specifically asked it to build a module? > > > > You were just asking it to build a subdirectory, not a specific > > individual file, and when you do that it looks at the configuration > > settings. > > > > I see. > > > It's always good to ensure that you actually build the files you modify > > before sending patches out. > > Sorry, I googled about building a single module, and thought running > that command would have built it. Moreover, since the change was so > simple I didn't suspect anything when it got built correctly the first > time around. > > I didn't look at how/where was the macro called and missed a very > obvious error. Now that I have looked at it, the only way I can think of > fixing this is changing the macro to a (inline?) function. Will > that be a desirable change? No, it can't be a function, the code is fine as-is, checkpatch is just a perl script and does not always know what needs to be done. thanks, greg k-h

5 years, 3 months

Re: [greybus-dev] [PATCH] staging: greybus: fix gb_loopback_stats_attrs definition

by Greg KH

On Fri, May 14, 2021 at 07:53:57PM +0530, Shreyansh Chouhan wrote: > On Fri, May 14, 2021 at 04:05:32PM +0200, Greg KH wrote: > > On Fri, May 14, 2021 at 07:18:38PM +0530, Shreyansh Chouhan wrote: > > > On Fri, May 14, 2021 at 03:36:25PM +0200, Greg KH wrote: > > > > On Fri, May 14, 2021 at 07:00:39PM +0530, Shreyansh Chouhan wrote: > > > > > The gb_loopback_stats_attrs macro, (defined in loopback.c,) is a > > > > > multiline macro whose statements were not enclosed in a do while > > > > > loop. > > > > > > > > > > This patch adds a do while loop around the statements of the said > > > > > macro. > > > > > > > > > > Signed-off-by: Shreyansh Chouhan <chouhan.shreyansh630(a)gmail.com> > > > > > --- > > > > > drivers/staging/greybus/loopback.c | 10 ++++++---- > > > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > > > > > diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c > > > > > index 2471448ba42a..c88ef3e894fa 100644 > > > > > --- a/drivers/staging/greybus/loopback.c > > > > > +++ b/drivers/staging/greybus/loopback.c > > > > > @@ -162,10 +162,12 @@ static ssize_t name##_avg_show(struct device *dev, \ > > > > > } \ > > > > > static DEVICE_ATTR_RO(name##_avg) > > > > > > > > > > -#define gb_loopback_stats_attrs(field) \ > > > > > - gb_loopback_ro_stats_attr(field, min, u); \ > > > > > - gb_loopback_ro_stats_attr(field, max, u); \ > > > > > - gb_loopback_ro_avg_attr(field) > > > > > +#define gb_loopback_stats_attrs(field) \ > > > > > + do { \ > > > > > + gb_loopback_ro_stats_attr(field, min, u); \ > > > > > + gb_loopback_ro_stats_attr(field, max, u); \ > > > > > + gb_loopback_ro_avg_attr(field); \ > > > > > + } while (0) > > > > > > > > > > #define gb_loopback_attr(field, type) \ > > > > > static ssize_t field##_show(struct device *dev, \ > > > > > -- > > > > > 2.31.1 > > > > > > > > > > > > > > > > > > Did you test build this change? > > > > > > I built the module using make -C . M=drivers/staging/greybus to test > > > build it. I didn't get any errors. > > > > Really? Can you provide the full build output for this file with your > > change? I don't think you really built this file for the obvious > > reasons... > > I ran make -C . M=drivers/staging/greybus > > I got a three line output saying: > make: Entering directory '/work/linux' > MODPOST drivers/staging/greybus//Module.symvers > make: Leaving directory '/work/linux' > > I just tried rebuilding the kernel with CONFIG_GREYBUS=m, and now I can > see what you are talking about. Why weren't these errors reported when I > ran the previous make command? Does that too check for the config > variables even when I specifically asked it to build a module? You were just asking it to build a subdirectory, not a specific individual file, and when you do that it looks at the configuration settings. It's always good to ensure that you actually build the files you modify before sending patches out. thanks, greg k-h

5 years, 3 months

Re: [greybus-dev] [PATCH] staging: greybus: fix gb_loopback_stats_attrs definition

by Greg KH

On Fri, May 14, 2021 at 07:18:38PM +0530, Shreyansh Chouhan wrote: > On Fri, May 14, 2021 at 03:36:25PM +0200, Greg KH wrote: > > On Fri, May 14, 2021 at 07:00:39PM +0530, Shreyansh Chouhan wrote: > > > The gb_loopback_stats_attrs macro, (defined in loopback.c,) is a > > > multiline macro whose statements were not enclosed in a do while > > > loop. > > > > > > This patch adds a do while loop around the statements of the said > > > macro. > > > > > > Signed-off-by: Shreyansh Chouhan <chouhan.shreyansh630(a)gmail.com> > > > --- > > > drivers/staging/greybus/loopback.c | 10 ++++++---- > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c > > > index 2471448ba42a..c88ef3e894fa 100644 > > > --- a/drivers/staging/greybus/loopback.c > > > +++ b/drivers/staging/greybus/loopback.c > > > @@ -162,10 +162,12 @@ static ssize_t name##_avg_show(struct device *dev, \ > > > } \ > > > static DEVICE_ATTR_RO(name##_avg) > > > > > > -#define gb_loopback_stats_attrs(field) \ > > > - gb_loopback_ro_stats_attr(field, min, u); \ > > > - gb_loopback_ro_stats_attr(field, max, u); \ > > > - gb_loopback_ro_avg_attr(field) > > > +#define gb_loopback_stats_attrs(field) \ > > > + do { \ > > > + gb_loopback_ro_stats_attr(field, min, u); \ > > > + gb_loopback_ro_stats_attr(field, max, u); \ > > > + gb_loopback_ro_avg_attr(field); \ > > > + } while (0) > > > > > > #define gb_loopback_attr(field, type) \ > > > static ssize_t field##_show(struct device *dev, \ > > > -- > > > 2.31.1 > > > > > > > > > > Did you test build this change? > > I built the module using make -C . M=drivers/staging/greybus to test > build it. I didn't get any errors. Really? Can you provide the full build output for this file with your change? I don't think you really built this file for the obvious reasons... thanks, greg k-h

5 years, 3 months

← Newer
1
...
53
54
55
56
57
58
59
...
86
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev