[greybus-dev] Re: [PATCH] staging: greybus: uart: return tty_alloc_driver() errors

On Mon, Jul 13, 2026 at 10:38:45PM +0530, Alfie Varghese wrote:

gb_tty_init() maps any tty_alloc_driver() failure to -ENOMEM. This loses the real errno returned by the driver core and makes failures harder to diagnose correctly.

Return PTR_ERR(gb_tty_driver) instead so callers receive the actual failure reason while preserving the existing cleanup path.

Signed-off-by: Alfie Varghese alfievarghese22@gmail.com

I don't have a problem with this change but the commit message should say that tty_alloc_driver() in this case always returns -ENOMEM so this is just a style fix and not anything which matters.

regards, dan carpenter