Hi Dan, You're right. The attribute output is what userspace reads, so adding the newline changes the ABI. My commit message was wrong to call it a non-functional change. I checked these attributes: no Documentation/ABI entry and no in-tree readers. Out-of-tree consumers are still possible. Please drop the patch. I'm withdrawing it, since a v2 would still rest on a checkpatch warning. regards, Chhabilal Dangal