On Thu, Oct 29, 2026 at 02:11:22PM +0100, Jose Nieto wrote:
The sysfs show() callbacks must emit a trailing newline. Commit 14c91651df34 ("staging: greybus: audio: Use sysfs_emit in show functions") converted them to sysfs_emit() but dropped the newline. Restore it.
This would have been a convincing argument, but it's not true.
- return sprintf(buf, "%s", module->desc.name); + return sysfs_emit(buf, "%s", module->desc.name);
There was never a newline and adding one now is a change to the user space API. We are allowed to change the API so long as it doesn't break anything but no one has been able to check.
We have recieved this same patch over a dozen times now. :P It has become a challenge to keep rejecting it over and over... But I am a stuborn person and the whole point of staging is to teach good habbits.
regards, dan carpenter