[greybus-dev] Re: [PATCH] greybus: audio: extract topology size retrieval into a helper

Hi Dan,

Thanks for the feedback. I understand and will focus on more meaningful changes next time.

Best regards, Hungyu

On Mon, Apr 13, 2026 at 12:04 AM Dan Carpenter error27@gmail.com wrote:

On Sat, Apr 11, 2026 at 06:20:55PM +0000, Hungyu Lin wrote:

...

The topology retrieval code currently mixes the size query with allocation and data fetch in a single function.

Extract the size query into a helper to make the control flow clearer.

No functional change.

Signed-off-by: Hungyu Lin dennylin0707@gmail.com

drivers/staging/greybus/audio_gb.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-)

I don't see how this is a cleanup at all...

If you were the maintainer of the code, then you could do whatever you want, but this is your first kernel patch.

regards, dan carpenter