On Monday, August 16, 2021 4:46:08 PM CEST Alex Elder wrote:
On 8/14/21 1:11 PM, Fabio M. De Francesco wrote:
Convert greybus/uart.c from IDR to XArray. The abstract data type XArray is more memory-efficient, parallelisable, and cache friendly. It takes advantage of RCU to perform lookups without locking. Furthermore, IDR is deprecated because XArray has a better (cleaner and more consistent) API.
I haven't verified the use of the new API (yet) but I have a few comments on your patch, below.
-Alex
Dear Alex,
On August 16th I submitted the v3 of my patch ("staging: greybus: Convert uart.c from IDR to XArray"), with changes based on the comments you provided.
Could you please take a few minutes to review this too? I would really appreciate it.
The v3 patch is at https://lore.kernel.org/lkml/20210816195000.736-1-fmdefrancesco@gmail.com/
Thanks,
Fabio
P.S.: I'd also like to know if you think it's worth converting IDA to XArray in order to improve the Greybus driver in staging.