On Tue, Jul 14, 2026 at 12:42:04PM +0530, Alfie Varghese wrote:
gb_tty_init() maps any tty_alloc_driver() failure to -ENOMEM. tty_alloc_driver() currently always returns -ENOMEM on failure, so this does not change behavior in practice. However, returning PTR_ERR(gb_tty_driver) is more correct and consistent with kernel conventions, preserving any future error codes the function might return.
Signed-off-by: Alfie Varghese alfievarghese22@gmail.com
v2: updated commit message per Dan Carpenter's review to clarify that tty_alloc_driver() currently only returns -ENOMEM, making this a style fix rather than a behavioral change.
drivers/staging/greybus/uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 7d060b4cd33d..24b4dab069c3 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -951,7 +951,7 @@ static int gb_tty_init(void) if (IS_ERR(gb_tty_driver)) { pr_err("Can not allocate tty driver\n");
- retval = -ENOMEM;
- retval = PTR_ERR(gb_tty_driver);
goto fail_unregister_dev; }
Something went really wrong with this patch, it is corrupted :(