[greybus-dev] Unitialized Variable and Null Pointer Dereference bug in gb_bootrom_get_firmware

Hi maintainers,

I would like to send one bug report.

In gb_bootrom_get_firmware, if the first branch is satisfied, it will go to queue_work, leading to the dereference of uninitialized const variable "fw". If the second branch is satisfied, it will go to unlock with fw as NULL pointer, leading to a NULL Pointer Dereference.

The Fixes commit should be [1], introducing the dereference of "fw" in the error handling code.

I am not sure how to fix this bug. Any comment on removing the dereference of fw?

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i...

-- My best regards to you.

No System Is Safe! Dongliang Mu