On Thu, Apr 30, 2026 at 01:54:36PM -0400, Bentley Blacketer wrote:
The original dev_info call was intentionally temporary, with a FIXME comment noting it should be downgraded to dev_dbg once modules with valid VID/PID values were common. Project Ara was cancelled in 2016, so that time has long passed.
But other systems are now using greybus, and there was at least 2 different phone models that shipped with this code. So are you sure that there is no user for this anymore?
Remove the FIXME comment and downgrade to dev_dbg as originally intended.
Tested via code inspection only, as Project Ara hardware is no longer available.
You can run greybus on a beaglebone device today.
Signed-off-by: Bentley Blacketer sonionwhat@gmail.com
You have an extra ' ' in there still.
Changes in v4:
- Fixed duplicate Signed-off-by
- Fixed missing tab on snprintf line
Changes in v3:
- Fixed author name mismatch
Changes in v2:
- Fixed whitespace issues
- Moved testing note below --- line
drivers/staging/greybus/bootrom.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c index 83921d90c..9e0f24d6d 100644 --- a/drivers/staging/greybus/bootrom.c +++ b/drivers/staging/greybus/bootrom.c @@ -168,13 +168,8 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage) intf->ddbl1_manufacturer_id, intf->ddbl1_product_id, intf->vendor_id, intf->product_id);
- // FIXME:
- // Turn to dev_dbg later after everyone has valid bootloaders with good
- // ids, but leave this as dev_info for now to make it easier to track
- // down "empty" vid/pid modules.
- dev_info(&connection->bundle->dev, "Firmware file '%s' requested\n",
- dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n", firmware_name);
Why did you drop the blank line too?
thanks,
greg k-h