[greybus-dev] Re: [PATCH] staging: greybus: loopback: Add comment for mutex definition

On Sun, Aug 02, 2026 at 10:06:09PM -0400, Noah Techoueyres wrote:

Add a comment to the mutex field explaining what it protects, as required by kernel coding style for lock definitions.

Signed-off-by: Noah Techoueyres noahtechoueyres@gmail.com

drivers/staging/greybus/loopback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index c33b8aa5871c..f94077a9d64b 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -61,7 +61,7 @@ struct gb_loopback { struct dentry *file; struct kfifo kfifo_lat;

• struct mutex mutex;

• struct mutex mutex; /* Protects sysfs attributes */

This comment is wrong.

regards, dan carpenter

struct task_struct *task; struct device *dev; wait_queue_head_t wq; -- 2.43.0