Hi Greg,
Thanks for the feedback. Based on my research, the only commercial products to ship with Greybus were Motorola Moto Mods (discontinued) and the original Project Ara hardware. BeagleConnect Freedom uses Greybus but for IoT prototyping rather than the bootrom firmware loading path this code covers.
Given that, I believe the VID/PID "empty module" concern the original FIXME references is no longer relevant in practice. However if you're aware of active hardware where this bootrom path is still exercised with potentially empty VID/PIDs, I'm happy to keep it as dev_info.
I'll send v5 fixing the extra space in Signed-off-by and restoring the blank line regardless.
Regards, Bentley