[greybus-dev] Re: [PATCH] staging: greybus: add missing newlines to sysfs_emit() output

On Sat, May 16, 2026 at 12:33:42AM +0200, Yousef Alhouseen wrote:

Sysfs show() callbacks should emit a trailing newline for text output. Several Greybus audio manager module attributes currently omit the newline, which triggers checkpatch warnings and makes the attributes less convenient to read from userspace.

Append missing newlines to the affected sysfs_emit() format strings.

Signed-off-by: Yousef Alhouseen alhouseenyousef@gmail.com

Patches which affect the user space ABI need to be tested properly before they can be merged. It's just to risky to start changing things randomly. If it were fixing something then that would be different, but just making checkpatch happy is not motivation enough.

regards, dan carpenter