[greybus-dev] Re: [staging] staging: greybus: loopback: add missing comment for mutex

On Mon, Jun 22, 2026 at 09:57:21AM +0530, Arnav Kapoor wrote:

Add a comment for the mutex as suggested by checkpatch.

Signed-off-by: Arnav Kapoor kapoorarnav43@gmail.com

The subject line should have [PATCH] in it, right?

---

drivers/staging/greybus/loopback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index ea57b1f5d..bf827e672 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -61,7 +61,7 @@ struct gb_loopback { struct dentry *file; struct kfifo kfifo_lat;

• struct mutex mutex;

• struct mutex mutex; /* protects the entire structure */

Look on the mailing list for other places where this type of change was rejected as it doesn't really explain anything.

thanks,

greg k-h