On Mon, Nov 02, 2026 at 07:34:38PM +0530, Adhyansh Verma wrote:
Per Documentation/filesystems/sysfs.rst and kernel conventions, sysfs show functions should terminate formatted attribute outputs with a newline character.
Commit 14c91651df34 ("staging: greybus: audio: Use sysfs_emit in show functions") converted sprintf() to sysfs_emit(), but left out the trailing newlines. As a result, reading these attributes in userspace outputs values without a line break and checkpatch warns that sysfs_emit() formats should include a terminating newline.
Add the terminating newline to each sysfs_emit() format string in audio_manager_module.c show callbacks.
Fixes: 14c91651df34 ("staging: greybus: audio: Use sysfs_emit in show functions") Signed-off-by: Adhyansh Verma adhyanshverma2010@gmail.com
Check the archives (lore.kernel.org) for why we aren't merging this.
regards, dan carpenter