On 10/22/26 6:02 AM, pavankumaryalagada@gmail.com wrote:
From: Yalagada Pavan Kumar pavankumaryalagada@gmail.com
In the loopback function, usleep_range() is used for short delays and msleep() for longer delays. This requires choosing the delay function based on the requested time and converting microseconds to milliseconds when using msleep().
Replace both functions with fsleep(), which selects a suitable delay method based on the requested time. This avoids the need to choose the delay function and convert the time manually.
Suggested-by: Alex Elder elder@riscstar.com Signed-off-by: Yalagada Pavan Kumar pavankumaryalagada@gmail.com
Your description above is pretty good, but I agree with Johan's comment. In fact, you should think about and understand exactly how that behavior changes with the switch to using fsleep(). - When would the delay be different from before? - When it differs--by how much does it differ? - Is this amount significant? And the third question gets at exactly what Johan was saying should be included in the patch description.
We want to know not just the mechanics of the change, but at a higher level, what is its effect?
You don't need to provide a super high level of detail in this particular change, but you should demonstrate somehow that you've thought about these things.
Please submit a new version of the patch and reword the description a bit to concisely capture why it makes sense to make the change, and why you believe that the change in behavior is likely harmless.
Thanks.
-Alex
drivers/staging/greybus/loopback.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index efc69c10cffe..2fe845eaef29 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -898,12 +898,8 @@ static int gb_loopback_fn(void *data) gb->send_count++; mutex_unlock(&gb->mutex);
if (us_wait) {if (us_wait < 20000)usleep_range(us_wait, us_wait + 100);elsemsleep(us_wait / 1000);}
if (us_wait)fsleep(us_wait);gb_pm_runtime_put_autosuspend(bundle);