On Wed, 14 Oct 2026, Jeremy Dean Clifton wrote:
Previous commit removing a function definition did not remove the function prototype.
Please use proper English.
The commit 3228900f80c2 ("staging: greybus: Remove unused function 'to_fw_mgmt_connection'") removing a function definition did not remove the function prototype.
commit 3228900f80c2 ("staging: greybus: Remove unused function 'to_fw_mgmt_connection'")
Function header declaration needs to be removed after definition removal.
This is saying what you did. It should be in the imperative:
Remove the prototype.
There is no definition of this function nor is there any place where it is called.
Not sure this is needed, since the definition was removed previously.
julia
Signed-off-by: Jeremy Dean Clifton deaner92@yahoo.com
v2: Fix grammar and spelling in commit message.
drivers/staging/greybus/firmware.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/firmware.h b/drivers/staging/greybus/firmware.h index 5d2564462ffc..04a67d2d5b8f 100644 --- a/drivers/staging/greybus/firmware.h +++ b/drivers/staging/greybus/firmware.h @@ -22,7 +22,6 @@ /* Firmware Management Protocol specific functions */ int fw_mgmt_init(void); void fw_mgmt_exit(void); -struct gb_connection *to_fw_mgmt_connection(struct device *dev); int gb_fw_mgmt_request_handler(struct gb_operation *op); int gb_fw_mgmt_connection_init(struct gb_connection *connection); void gb_fw_mgmt_connection_exit(struct gb_connection *connection); -- 2.43.0