Hi,
On 1/30/23 14:26, Thomas Weißschuh wrote:
Hi Hans,
On Mon, Jan 30, 2023 at 09:36:32AM +0100, Hans de Goede wrote:
Hi,
On 1/30/23 04:59, Thomas Weißschuh wrote:
Since 52d225346904 ("HID: Make lowlevel driver structs const") the lowlevel HID drivers are only exposed as const.
Take advantage of this to constify the underlying structures, too.
Signed-off-by: Thomas Weißschuh linux@weissschuh.net
Thanks, series looks good to me:
Reviewed-by: Hans de Goede hdegoede@redhat.com
I'll also pick up / merge patches 7 + 8 into pdx86/for-next sometime this week.
Please note that patch 7 depends on commit 52d225346904 ("HID: Make lowlevel driver structs const") which is not yet in Linus' tree, only in the HID tree (branch for-6.3/hid-core).
Maybe it's better to take it via the HID tree or I can resend when the prerequisites are in Linus' tree.
Ah yes then it would be better to take the entire set through the HID tree, here is my ack for that:
Reviewed-by: Hans de Goede hdegoede@redhat.com
Regards,
Hans
Thomas Weißschuh (9): HID: amd_sfh: Constify lowlevel HID driver HID: hyperv: Constify lowlevel HID driver HID: logitech-dj: Constify lowlevel HID driver HID: steam: Constify lowlevel HID driver HID: intel-ish-hid: Constify lowlevel HID driver HID: surface-hid: Constify lowlevel HID driver platform/x86: asus-tf103c-dock: Constify lowlevel HID driver platform/x86: asus-tf103c-dock: Constify toprow keymap staging: greybus: hid: Constify lowlevel HID driver
drivers/hid/amd-sfh-hid/amd_sfh_hid.c | 2 +- drivers/hid/hid-hyperv.c | 2 +- drivers/hid/hid-logitech-dj.c | 4 ++-- drivers/hid/hid-steam.c | 2 +- drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- drivers/hid/surface-hid/surface_hid_core.c | 2 +- drivers/platform/x86/asus-tf103c-dock.c | 4 ++-- drivers/staging/greybus/hid.c | 2 +- 8 files changed, 10 insertions(+), 10 deletions(-)
base-commit: e04955db6a7c3fc4a1e6978649b61a6f5f8028e3 change-id: 20230130-hid-const-ll-driver-fcfdd3af11b8
Best regards,