On 10/13/26 4:43 PM, Yalagada Pavan Kumar wrote:
I think your suggested change is a net positive, but doing it in some spots but not others means it is adding a bit of inconsistency.
I agree that similar cases elsewhere in Greybus are worth checking to keep error reporting consistent. I will look at the other Greybus files for cases where using %pe would be appropriate.
Would you prefer me to extend this change to the other relevant Greybus files, or keep this patch focused on fw-core.c and submit a separate patch for the remaining changes?
I guess I mainly wanted to understand your intent. I don't really mind your proposed change, but I would really prefer to have it be part of an overall plan to upgrade all error messages this way.
Ideally error (and other) messages are done consistently, and so changing them in just one file sort of raises a flag for me.
Can you survey the messages elsewhere in the Greybus code and get a sense of how much work it will be to do this comprehensively? Your current patch affects four spots in one source file; how many others would there be?
And if updating everything is a task you're willing to do, then I think I would prefer you extend this change.
-Alex