On Thu, Jul 27, 2017 at 09:49:32PM -0700, Greg KH wrote:
On Mon, Jul 24, 2017 at 10:08:37AM +0300, Dan Carpenter wrote:
I don't understand why greybus has to be special instead of the same as everything else. Who cares about this stuff really? Just do whatever is easiest and most common.
It's not special, and --strict should apply here as long as it is in staging. So I'll apply these types of things to prevent people from feeling like they wasted their time fixing something up and getting it rejected for no good reason.
Your call, but I do think that this is taking the checkpatch exercise too far.
What we're talking about here are neither checkpatch ERRORs nor WARNINGs, but that third category of CHECK notifications that are output only when the switch --strict, or it's more aptly named alias --subjective, is specified.
Just like we don't blindly apply patches addressing every ERROR or WARNING, I think we should not accept every patch addressing these subjective CHECK notifications.
These flags are useful when people are submitting new code; and most of the CHECKs enabled by --subjective do seem reasonable, at least in my (subjective) opinion.
I personally think that neither OPEN_PARENTHESIS nor LINE_SPACING do or should apply everywhere however, and that the final call should be left up to the author and/or maintainer of the code in question.
But yes, greybus is still in staging so it is ultimately your call.
I will see if I can find some spare cycles to start migrating at least the core bits out of staging either way.