Re: [greybus-dev] [PATCH] greybus: remove excessive check in gb_connection_hd_cport_quiesce()

On Thu, Sep 26, 2019 at 12:36:56AM +0300, Denis Efremov wrote:

Function pointer "hd->driver->cport_quiesce" is already checked at the beginning of gb_connection_hd_cport_quiesce(). Thus, the second check can be removed.

Signed-off-by: Denis Efremov efremov@linux.com

drivers/greybus/connection.c | 3 --- 1 file changed, 3 deletions(-)

diff --git a/drivers/greybus/connection.c b/drivers/greybus/connection.c index fc8f57f97ce6..e3799a53a193 100644 --- a/drivers/greybus/connection.c +++ b/drivers/greybus/connection.c @@ -361,9 +361,6 @@ static int gb_connection_hd_cport_quiesce(struct gb_connection *connection) if (connection->mode_switch) peer_space += sizeof(struct gb_operation_msg_hdr);

• if (!hd->driver->cport_quiesce)

• return 0;
  

• ret = hd->driver->cport_quiesce(hd, connection->hd_cport_id, peer_space, GB_CONNECTION_CPORT_QUIESCE_TIMEOUT);

Nice catch, thanks.

Acked-by: Johan Hovold johan@kernel.org