On Fri, Sep 04, 2026 at 05:56:25AM +0000, contectforbusiness@proton.me wrote:
checkpatch complains about:
CHECK: struct mutex definition without comment
Add short comments describing what each mutex protects.
Is this an AI patch? Why write a short description? That's the opposite of what I want. I want a complete analysis.
The channel lock protects the channel state and lights_lock protects the lights array.
No functional change, just quiets checkpatch.
Signed-off-by: Vaibhav contectforbusiness@proton.me
drivers/staging/greybus/light.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index cab02b5da..a036fa2a0 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -37,7 +37,7 @@ struct gb_channel { bool releasing; bool strobe_state; bool active;
- struct mutex lock;
- struct mutex lock; /* protects channel */
This comment is useless and wrong.
I hate this checkpatch warning...
regards, dan carpenter