Hi Dan,
Thanks, that makes sense now. The point isn't just showing the code is buggy, it's explaining why changing a years-old return value is safe, and that belongs in the commit message rather than the thread.
I'll write that reasoning in next time (what checks the return, what doesn't, and what could be affected) instead of leaving reviewers to ask.
Appreciate you taking the time to walk me through it.
Hao-Qun