On Mon, May 07, 2018 at 10:35:46AM +0530, Viresh Kumar wrote:

On 05-05-18, 23:50, Nathan Chancellor wrote:

...

Fixes the following W=1 warning: variable ‘intf_id’ set but not used [-Wunused-but-set-variable]

Signed-off-by: Nathan Chancellor natechancellor@gmail.com

drivers/staging/greybus/svc.c | 3 --- 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/greybus/svc.c b/drivers/staging/greybus/svc.c index a874fed761a1..a2bb7e1a3db3 100644 --- a/drivers/staging/greybus/svc.c +++ b/drivers/staging/greybus/svc.c @@ -1137,7 +1137,6 @@ static int gb_svc_intf_reset_recv(struct gb_operation *op) struct gb_svc *svc = gb_connection_get_data(op->connection); struct gb_message *request = op->request; struct gb_svc_intf_reset_request *reset;

• u8 intf_id;

if (request->payload_size < sizeof(*reset)) { dev_warn(&svc->dev, "short reset request received (%zu < %zu)\n", @@ -1146,8 +1145,6 @@ static int gb_svc_intf_reset_recv(struct gb_operation *op) } reset = request->payload;

• intf_id = reset->intf_id;
• /* FIXME Reset the interface here */

return 0;

Don't you get a new error after removing this, i.e "reset set but unused" ? Or the sizeof() operation on that suppresses those warnings ..

That was my initial reaction as well, but I failed to notice the sizeof which prevents the new warning.

Acked-by: Viresh Kumar viresh.kumar@linaro.org

Acked-by: Johan Hovold johan@kernel.org

Thanks, Johan