Signed-off-by: Gaurav Dhingra gauravdhingra.gxyd@gmail.com --- Changes in v2: - use correct format for multiline comment --- drivers/staging/greybus/audio_codec.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h index a1d5440..4efd8b3 100644 --- a/drivers/staging/greybus/audio_codec.h +++ b/drivers/staging/greybus/audio_codec.h @@ -23,7 +23,10 @@ enum { NUM_CODEC_DAIS, };
-/* device_type should be same as defined in audio.h (Android media layer) */ +/* + * device_type should be same as defined in audio.h + * (Android media layer) + */ enum { GBAUDIO_DEVICE_NONE = 0x0, /* reserved bits */
On Fri, Apr 6, 2018 at 3:39 PM, Gaurav Dhingra gauravdhingra.gxyd@gmail.com wrote:
Why did you remove the commit log? You had the right one in v1.
Signed-off-by: Gaurav Dhingra gauravdhingra.gxyd@gmail.com
Changes in v2: - use correct format for multiline comment
drivers/staging/greybus/audio_codec.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h index a1d5440..4efd8b3 100644 --- a/drivers/staging/greybus/audio_codec.h +++ b/drivers/staging/greybus/audio_codec.h @@ -23,7 +23,10 @@ enum { NUM_CODEC_DAIS, };
-/* device_type should be same as defined in audio.h (Android media layer) */ +/*
- device_type should be same as defined in audio.h
- (Android media layer)
- */
enum { GBAUDIO_DEVICE_NONE = 0x0, /* reserved bits */
This looks ok.
Hi,
On Friday 06 April 2018 03:52 PM, Viresh Kumar wrote:
On Fri, Apr 6, 2018 at 3:39 PM, Gaurav Dhingra gauravdhingra.gxyd@gmail.com wrote:
Why did you remove the commit log? You had the right one in v1.
I didn't realize that it would be necessary to add it to this patch set. I thought you guys will do squashing of the commits (v2 and v1) and using just one commit message (and will take it from last commit), seems like I was wrong. Now I've understood it.
Signed-off-by: Gaurav Dhingra gauravdhingra.gxyd@gmail.com
Changes in v2: - use correct format for multiline comment
drivers/staging/greybus/audio_codec.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h index a1d5440..4efd8b3 100644 --- a/drivers/staging/greybus/audio_codec.h +++ b/drivers/staging/greybus/audio_codec.h @@ -23,7 +23,10 @@ enum { NUM_CODEC_DAIS, };
-/* device_type should be same as defined in audio.h (Android media layer) */ +/*
- device_type should be same as defined in audio.h
- (Android media layer)
- */ enum { GBAUDIO_DEVICE_NONE = 0x0, /* reserved bits */
This looks ok.
Do I now need to send v3 with these exact changes, since I missed the 'commit log' in this one?
On 06-04-18, 16:02, Gaurav Dhingra wrote:
I didn't realize that it would be necessary to add it to this patch set. I thought you guys will do squashing of the commits (v2 and v1) and using just one commit message (and will take it from last commit), seems like I was wrong. Now I've understood it.
:)
When you send V2, it doesn't have any dependency on V1 and V1 is discarded after that point. V2 is the full patch which should be applied alone, we mention V2 in subject so that it is easier to track the versions.
Signed-off-by: Gaurav Dhingra gauravdhingra.gxyd@gmail.com
Changes in v2: - use correct format for multiline comment
drivers/staging/greybus/audio_codec.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h index a1d5440..4efd8b3 100644 --- a/drivers/staging/greybus/audio_codec.h +++ b/drivers/staging/greybus/audio_codec.h @@ -23,7 +23,10 @@ enum { NUM_CODEC_DAIS, };
-/* device_type should be same as defined in audio.h (Android media layer) */ +/*
- device_type should be same as defined in audio.h
- (Android media layer)
- */
enum { GBAUDIO_DEVICE_NONE = 0x0, /* reserved bits */
This looks ok.
Do I now need to send v3 with these exact changes, since I missed the 'commit log' in this one?
Yes please.
-
Gaurav Dhingra -
Viresh Kumar